Partial refactoring of the s-pipes-core #432
Conversation
|
@MSattrtand please rebase (not urgent) |
MSattrtand
force-pushed
the
refactor-s-pipes-core
branch
2 times, most recently
from
423895e to
e25a4ac
Compare
|
|
||
| @Parameter(iri = SML.replace) | ||
| private boolean isReplace = false; | ||
| private final boolean isReplace = false; |
There was a problem hiding this comment.
this does not make sense to make final because it is parameter of module
There was a problem hiding this comment.
reverted see my last commits and resolve after you read this.
| private static String getValuesClauseValues(ResultSet resultSet, int rowsCount) { | ||
|
|
||
| StringBuffer valuesBuffer = new StringBuffer(); | ||
| StringBuilder valuesBuffer = new StringBuilder(); |
There was a problem hiding this comment.
What is the reason for this?
| "\n\t - exception [3]: \"\n{}\n\"" | ||
| , query, bindings, getStackTrace(ex)); | ||
| log.error(""" | ||
| Failed execution of query [1] for binding [2], due to exception [3]. \ |
There was a problem hiding this comment.
| Failed execution of query [1] for binding [2], due to exception [3]. \ | |
| Failed execution of query [1] for binding [2], due to exception [3]. |
There was a problem hiding this comment.
Not sure why you need this ... also check for other "" as well
blcham
force-pushed
the
refactor-s-pipes-core
branch
from
a7c85bc to
9ad2b05
Compare
| public class SPINEnhancedNodeFactory extends Implementation { | ||
| private final Node type; | ||
| private Constructor enhNodeConstructor; | ||
| private Constructor<?> enhNodeConstructor; |
There was a problem hiding this comment.
You removed the warning but did not really solve the issue that the warning was indicating .. see my last commits
|
|
||
| } | ||
|
|
||
| @Disabled |
There was a problem hiding this comment.
Please go over all your changes within this PR and put back all @disabled tests ... I would like to address this outside of this issue ... in most cases i will want to implement those tests
2 participants
Resolves partially #324