Partial refactoring of the s-pipes-core #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@MSattrtand please rebase (not urgent) |
MSattrtand
force-pushed
the
refactor-s-pipes-core
branch
2 times, most recently
from
423895e to
e25a4ac
Compare
blcham
requested changes
Oct 19, 2025
s-pipes-core/src/main/java/cz/cvut/spipes/modules/BindBySelectModule.java
Outdated
Show resolved
Hide resolved
blcham
force-pushed
the
refactor-s-pipes-core
branch
from
a7c85bc to
9ad2b05
Compare
blcham
requested changes
Oct 19, 2025
s-pipes-core/src/main/java/cz/cvut/spipes/spin/util/SPINEnhancedNodeFactory.java
Outdated
Show resolved
Hide resolved
s-pipes-core/src/test/java/cz/cvut/spipes/modules/AbstractModuleTest.java
Show resolved
Hide resolved
blcham
requested changes
Oct 21, 2025
Contributor
blcham
left a comment
blcham
left a comment
There was a problem hiding this comment.
Can you investigate following files as discussed on meeting?
s-pipes-core/src/main/java/cz/cvut/spipes/modules/handlers/CharacterHandler.java
Show resolved
Hide resolved
s-pipes-core/src/main/java/cz/cvut/spipes/modules/handlers/ListSetter.java
Show resolved
Hide resolved
MSattrtand
force-pushed
the
refactor-s-pipes-core
branch
from
27e70d7 to
d34684b
Compare
- remove test prefix from the test - start test with the name of the method called
blcham
force-pushed
the
refactor-s-pipes-core
branch
from
4617586 to
f51e476
Compare
MSattrtand
force-pushed
the
refactor-s-pipes-core
branch
from
5257462 to
a205f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves partially #324