First pull request #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kyle,
I added files to config/import, lib, suite, and tests for the kfs branch just to get stuff going. I have a suite called "login" to be consistent with ks. It's pretty stripped down. I expect it to not successfully login. At this point, I want to checkin get the driver working.
I wonder if you would have a look at my code in the pull request because when I run the driver command:
/Users/r351574nc3/projects/git/Open-Performance-Automation-Framework/lib/../lib/tsung-api.rb:254:in
[]': Symbol as array index (TypeError) from /Users/r351574nc3/projects/git/Open-Performance-Automation-Framework/lib/../lib/tsung-api.rb:254:inadd'from /Users/r351574nc3/projects/git/Open-Performance-Automation-Framework/lib/kfs/common/authentication.rb:32:in `login'
from /Users/r351574nc3/projects/git/Open-Performance-Automation-Framework/tests/kfs/login.rb:31
I haven't looked to deeply into it, but is the tsung-api.rb proprietary to oae at all? I just wonder if I should be writing my own tooling for this or using what is there.