Skip to content

Conversation

Siddhi-agg
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kcl/kclvm/tools/src/LSP/src/tests.rs
kcl/kclvm/tools/src/LSP/src/state.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa
Copy link
Contributor

He1pa commented Apr 3, 2025

This may not work, because CI's tests will depend on the release version of kpm
image

@Siddhi-agg
Copy link
Contributor Author

@He1pa can you please rerun the CI so we can move forward with this PR?

@Siddhi-agg Siddhi-agg force-pushed the lsp-kpm-integration branch from 21841f3 to 8c0f729 Compare June 10, 2025 13:52
@Siddhi-agg
Copy link
Contributor Author

@He1pa One of the tests is working, I will look into the other one but can we merge this PR first?

@Siddhi-agg Siddhi-agg force-pushed the lsp-kpm-integration branch from ad93536 to 6266311 Compare August 5, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants