Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Rebase 1.32 #40

Merged
merged 7 commits into from
Feb 10, 2025
Merged

✨ Rebase 1.32 #40

merged 7 commits into from
Feb 10, 2025
+3,769 −2,999

Conversation

gman0
Copy link
Contributor

@gman0 gman0 commented Jan 8, 2025

Summary

Updated dependencies and regenerated client code for 1.32.

There are some missing features that are present in k/client-go -- see kcp-dev/code-generator#98.

Related issue(s)

Part of kcp-dev/kcp#3209

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2025
@kcp-ci-bot
Copy link
Contributor

Hi @gman0. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 8, 2025
@gman0
Copy link
Contributor Author

gman0 commented Jan 8, 2025

Regarding 22d0b2a

This was a convenient way to get in my not-yet-merged changes from kcp-dev/code-generator#98 and use that to generate client-go in this PR. I understand we're using the same hack/go-install.sh script in other repos in kcp-dev. Let me know if (1) you agree with the change, (2) should be in a separate PR, (3) should be propagated to the rest of our hack/go-install.sh scripts.

@gman0 gman0 marked this pull request as draft January 8, 2025 15:36
@kcp-ci-bot kcp-ci-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
@kcp-ci-bot kcp-ci-bot added dco-signoff: no Indicates the PR's author has not signed the DCO. and removed dco-signoff: yes Indicates the PR's author has signed the DCO. labels Jan 20, 2025
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Feb 7, 2025
@gman0
Update kcp-dev/apimachinery/v2 dependencies to latest
863fc9e 
Uses kcp-dev/apimachinery@cd7529a
which includes k/k 1.32 rebase.

On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
gman0 added 6 commits February 10, 2025 17:03
@gman0
Makefile: use golangci-lint v1.62.2
21ee740 
Needed for go1.23.

On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
Makefile: use kcp-dev/code-generator v2.4.0
321f353 
On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
Removed PodSchedulingContext
06f8b6f 
See kubernetes/client-go@d366fa7

On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
Removed coordination/v1alpha1 API
99cf7e4 
Coordination.v1alpha1 API is dropped and replaced with coordination.v1alpha2.
See kubernetes/kubernetes#127857

On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
prow: use build:1.23.4-1
62f7363 
On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0
Generated code
034dbe3 
Ran 'make codegen'

On-behalf-of: SAP robert.vasek@sap.com
Signed-off-by: Robert Vasek <robert.vasek@clyso.com>
@gman0 gman0 marked this pull request as ready for review February 10, 2025 16:21
@kcp-ci-bot kcp-ci-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2025
gman0
gman0 commented Feb 10, 2025
View reviewed changes
@mjudeikis
Copy link
Contributor

/lgtm
/approve
🚢 🇮🇹

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 13a9d724cb5489a5c390bfb5ac357c98b3bda9c4

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2025
@kcp-ci-bot kcp-ci-bot merged commit 5ae6774 into kcp-dev:main Feb 10, 2025
8 checks passed
@gman0 gman0 deleted the 1.32-prep branch February 10, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjudeikis mjudeikis

Assignees

@mjudeikis mjudeikis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gman0 @kcp-ci-bot @mjudeikis