WIP: Rebase 1.32 Pre.1 Diff by mjudeikis · Pull Request #161 · kcp-dev/kubernetes

mjudeikis · 2025-02-12T18:47:41Z

What type of PR is this?

What this PR does / why we need it:

Just a diff for visibility.
branch pre.1 was pushed to fork already.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Co-authored-by: Mangirdas Judeikis <mangirdas@judeikis.lt> Co-authored-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Signed-off-by: Mangirdas Judeikis <mangirdas@judeikis.lt>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

Partially reverting e8b1d7d. kcp's GC controller is event-based for now, and without locks we may miss events during monitor syncs. There are known issues that locking causes: * kubernetes#101078 * kubernetes#127105 On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

…_quota_controller_patch.go Ran: go run ./hack/kcp/resource_quota_controller_patch.go > pkg/controller/resourcequota/resource_quota_controller_patch.go and modified the resulting file so that imports are in place, and changed the main wait.UntilWithContext loop into a closure, so that when UpdateMonitors is called, updating is done exactly once. On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

…gecollector_patch.go Ran: go run ./hack/kcp/garbage_collector_patch.go > pkg/controller/garbagecollector/garbagecollector_patch.go and modified the resulting file so that imports are in place, and changed the main wait.UntilWithContext loop into a closure, so that when ResyncMonitors is called, syncing is done exactly once. On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

… pods Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

…gin and policy plugin framework Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…rge patch Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…ss identities Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…card partial metadata requests Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

… storage paths Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

… control plane Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

…dler patch Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

…ilder Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

…erver Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…in webhooks On-behalf-of: @SAP christoph.mewes@sap.com

On-behalf-of: @SAP christoph.mewes@sap.com

Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT> On-behalf-of: SAP mangirdas.judeikis@sap.com

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…bal service account Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…pers Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…bal service account fix Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…eign service account tests Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

…plify Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

…n and policy plugin framework On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

kcp doesn't implement protobuf codec yet, and so we need to disable it in the client code. This commit comments out --prefers-protobuf command line flag when invoking client-gen in update-codegen.sh scripts in various places. TODO: revert once kcp gains protobuf support. On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

Ran: hack/pin-dependency.sh github.com/kcp-dev/logicalcluster/v3 v3.0.5 hack/pin-dependency.sh github.com/kcp-dev/apimachinery/v2 v2.0.1-0.20250207161408-e1833e4a94f2 hack/pin-dependency.sh github.com/kcp-dev/client-go 5ae6774ab861f24965fc963d61af166c012f1ae0 On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

Ran: hack/update-vendor.sh On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

Ran: hack/update-codegen.sh On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

mjudeikis · 2025-02-12T19:11:58Z

pkg/serviceaccount/legacy.go

 		}

-		v.patchSecretWithLastUsedDate(ctx, secret)
+		now := time.Now().UTC()


This looks like could be replaced by the function it replaces. Strange change.

Indeed, and I've missed it, thanks!

https://github.com/kcp-dev/kubernetes/blob/kcp-1.31.0/pkg/serviceaccount/legacy.go#L176-L191

staging/src/k8s.io/apiserver/pkg/registry/rest/resttest/resttest.go

mjudeikis · 2025-02-12T19:21:09Z

staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go

-			if len(txnResp.Responses) == 0 || txnResp.Responses[0].GetResponseDeleteRange() == nil {
-				return errors.New(fmt.Sprintf("invalid DeleteRange response: %v", txnResp.Responses))
-			}
-			deleteResp := txnResp.Responses[0].GetResponseDeleteRange()
-			if deleteResp.Header == nil {
-				return errors.New("invalid DeleteRange response - nil header")
-			}
-			err = decode(s.codec, s.versioner, origState.data, out, deleteResp.Header.Revision, clusterName)
+			err = decode(s.codec, s.versioner, origState.data, out, txnResp.Revision, clusterName, shardName)


Do we remember why this is different from upstream?
@sttts maybe you recall?

Upstream's conditionalDelete was the same in v1.31.0 too: https://github.com/kubernetes/kubernetes/blob/v1.31.0/staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go#L349-L385

Now, instead of explicitly doing Txn-If-Then-Else-Commit, there is a dedicated OptimisticDelete, and so deleteResp is not used anymore. Is this what you meant, @mjudeikis ?

mjudeikis · 2025-02-12T19:22:16Z

staging/src/k8s.io/apiserver/pkg/clientsethack/adapter.go

+	clusterAware kcpkubernetesclientset.ClusterInterface
+}
+
+func (h *hack) AdmissionregistrationV1alpha1() admissionregistrationv1alpha1.AdmissionregistrationV1alpha1Interface {


im surprised this didn't changed

The Interface interface seems to still have that method in upstream's v1.32: https://github.com/kubernetes/kubernetes/blob/v1.32.0/staging/src/k8s.io/client-go/kubernetes/clientset.go#L27

Unless you meant something else, @mjudeikis ?

I mean no new types were added/removed in 1.32.

git diff kcp-1.31.0..kcp-1.32-pre.7-review -- staging/src/k8s.io/apiserver/pkg/clientsethack/adapter.go says that:

coordinationV1alpha1 was replaced by coordinationV1alpha2, and

resourceV1beta1 was added

Should I document this somewhere?

mjudeikis · 2025-02-12T19:23:08Z

pkg/controlplane/apiserver/config.go


 	ctx := wait.ContextForChannel(genericConfig.DrainedNotify())

-	// Use protobufs for self-communication.


TODO: This needs to be reverted once we add protoc support

mjudeikis · 2025-02-12T19:24:29Z

pkg/controlplane/apiserver/server.go

+		if err != nil {
+			return nil, fmt.Errorf("failed to create peer endpoint lease controller: %w", err)
+		}
+


needs to be dropped. There is no error here anymore.

Hmm seems to have been added by bf01714 by mistake? There doesn't seem to be anything creating an err there either. Thanks!

mjudeikis · 2025-02-12T19:25:39Z

staging/src/k8s.io/apiserver/pkg/server/options/admission.go

 	initializersChain := admission.PluginInitializers{genericInitializer}
 	initializersChain = append(initializersChain, pluginInitializers...)

-	admissionPostStartHook := func(hookContext server.PostStartHookContext) error {


Would be good to add comment this this is removed. I think history is bit lost.

Are there some docs I could link to? Originally removed in 3211e1f , but without details.

mjudeikis · 2025-02-12T19:26:36Z

pkg/controlplane/apiserver/options/options.go

+	if completed.Authorization != nil {
+		completed.Authorization.Complete()
+	}


Potentially quick upstream change and we can drop this.

We can actually drop this already, (*BuiltInAuthorizationOptions).Complete() already checks if the receiver is nil.

In v1.31.0, this was indeed not being checked: https://github.com/kubernetes/kubernetes/blob/v1.31.0/pkg/kubeapiserver/options/authorization.go#L87-L91

mjudeikis · 2025-02-12T19:27:59Z

staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/status_strategy.go

 	// track changed fields in the status update.
 	managedFields := newCustomResourceObject.GetManagedFields()

-	// KCP PATCH START


The fact this commit is here means we added in some before, and we need to clean and remove them.
This should not exist anymore.

Seems to have been added in c6b52ef . I'll try to go through it and see if there are any more leftovers from this.

Squashing this commit, 5c809ee UPSTREAM: <squash>: remove syncer custom code from apiextensions-apiserver into its origin, where this code comes from -- 879e48 UPSTREAM: <carry>: apiextensions-apiserver.

mjudeikis · 2025-02-12T19:30:56Z

staging/src/k8s.io/apiserver/pkg/endpoints/handlers/response.go

+
+	// kcp: needed for setKCPOriginalAPIVersionAnnotation().
+	// It expects a context with clusterContextKey key set.
+	ctx context.Context


:'( one more ctx wiring. Maybe we could try to get this upstreamed too as its apiserver code.

gman0 · 2025-02-18T12:02:22Z

Here are a couple of other commits that also seem to be squashable:

Commits for squashing	Commit to squash into	Need ok from
`d57c237ff9d` UPSTREAM: <squash>: prevent conflict with pre-existing auth annotation	`fe0acf78c52` UPSTREAM: <carry>: include cluster name in authz SubjectAccessReview in webhooks	@xrstf
`bffed1deb48` UPSTREAM: <squash>: authz: add warrants to default rule resolver: simplify `1b0b146401f` UPSTREAM: <squash>: authz: add warrants to default rule resolver: global service account fix `b06d2a8ad35` UPSTREAM: <squash>: authz: add warrants to default rule resolver: helpers `dc034064415` UPSTREAM: <squash>: authz: add warrants to default rule resolver: global service account	`b6ac17fbe4a` UPSTREAM: <carry>: authz: add warrants to default rule resolver	@sttts

Can you guys pls 👍 if you're ok with these changes?

UPSTREAM 130180: Make disable lookups of SA related artifacts working

sttts and others added 30 commits February 12, 2025 16:14

README

d157aea

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: controlplane/apiserver: add miniaggregator

a0f3d68

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: clusterize controllers

7234f81

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: Add kcp patchers

570c6ed

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: storage: etcd cluster key computation

f87a202

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: clusterize serviceaccounts

aad4a42

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: registry/core/serviceaccount: do not crash without…

86eb6a8

… pods Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: kube-aggregator

0e41242

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: INTERESTING: clusterize admission

006648f

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com> Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: Clusterize ValidatingAdmissionPolicy admission plu…

ba55bcf

…gin and policy plugin framework Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: clusterize storage hash

aaa0e92

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: endpoints: add Cluster struct for ctx

f2ad525

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: endpoints/patch: wire openapi for CRD strategic me…

4ed5b98

…rge patch Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: storage/etcd3: clusterize

4739ef6

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: apiserver: partial wildcard metadata request accro…

ab335e9

…ss identities Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: endpoints: set kcp.io/original-api-version on wild…

d868a62

…card partial metadata requests Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: watch(er/cache): clusterize

7f28105

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: apiserver: split chain into pre and post authz

e271562

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: apiserver: clusterize listed paths

4a2b5f9

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: apiserver: clusterize OpenAPI v2

b9669e3

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: clusterize BuiltInAuthenticationOptions

b5939d8

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: storage: add UseResourceAsPrefixDefault for legacy…

bf1a2a1

… storage paths Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: apiextensions-apiserver

879e485

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: cache-server: wire shard name into storage

0203da1

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: add client and informer hacks

db825b7

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: controlplane: wire informers and clients

1159daa

Co-authored-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Marvin Beckers <marvin@kubermatic.com> Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

embik and others added 24 commits February 12, 2025 18:22

UPSTREAM: <carry>: pass system:admin clients and informers in generic…

e142cc7

… control plane Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: remove REST mapper from admission plugins

a71d65e

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: provide supportedMediaTypes for custom resoure han…

68b54d6

…dler patch Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: prevent NPE if no authorization is set

50c9ea5

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: wrap CRD group into packagePrefix for OpenAPIV3 bu…

2034abe

…ilder Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <CARRY>: clusterize validatingadmissionpolicystatus controller

8a207b8

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>

UPSTREAM: <carry>: apiserver cleaning

7a27a28

UPSTREAM: <squash>: remove syncer custom code from apiextensions-apis…

5c809ee

…erver Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: include cluster name in authz SubjectAccessReview …

fe0acf7

…in webhooks On-behalf-of: @SAP christoph.mewes@sap.com

UPSTREAM: <squash>: prevent conflict with pre-existing auth annotation

d57c237

On-behalf-of: @SAP christoph.mewes@sap.com

CARRY: split auth/authz chains even more

455d854

Signed-off-by: Mangirdas Judeikis <Mangirdas@Judeikis.LT> On-behalf-of: SAP mangirdas.judeikis@sap.com

UPSTREAM: <carry>: authz: add scoping to default rule resolver

1a37a19

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: authz: add warrants to default rule resolver

b6ac17f

Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <squash>: authz: add warrants to default rule resolver: glo…

dc03406

…bal service account Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <squash>: authz: add warrants to default rule resolver: hel…

b06d2a8

…pers Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <squash>: authz: add warrants to default rule resolver: glo…

1b0b146

…bal service account fix Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <squash>: authz: add warrants to default rule resolver: for…

0ced631

…eign service account tests Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <squash>: authz: add warrants to default rule resolver: sim…

bffed1d

…plify Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>

UPSTREAM: <carry>: endpoints: wire in ctx to watchListTransformer

8fd95d6

On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

UPSTREAM: <carry>: Clusterize MutatingAdmissionPolicy admission plugi…

8befcaf

…n and policy plugin framework On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

UPSTREAM: <drop>: Updated vendor modules

204c308

Ran: hack/update-vendor.sh On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

UPSTREAM: <drop>: Re-generated client code

c6ebc59

Ran: hack/update-codegen.sh On-behalf-of: SAP robert.vasek@sap.com Signed-off-by: Robert Vasek <robert.vasek@clyso.com>

mjudeikis commented Feb 12, 2025

View reviewed changes

mjudeikis and others added 2 commits February 20, 2025 21:16

UPSTREAM 130180: Make disable lookups of SA related artifacts working

89e1549

Merge pull request #163 from mjudeikis/mjudeikis/cherry.sa.lookup

3b193fc

UPSTREAM 130180: Make disable lookups of SA related artifacts working

gman0 mentioned this pull request Apr 28, 2025

feature: rebase to Kubernetes 1.32.3 kcp-dev/kcp#3209

Closed

1 task

mjudeikis closed this Dec 9, 2025


		ctx := wait.ContextForChannel(genericConfig.DrainedNotify())

		// Use protobufs for self-communication.

Conversation

mjudeikis commented Feb 12, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gman0 Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gman0 Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gman0 Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gman0 Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gman0 Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gman0 commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gman0 Feb 17, 2025 •

edited

Loading

gman0 Feb 17, 2025 •

edited

Loading

gman0 Feb 17, 2025 •

edited

Loading

gman0 Feb 17, 2025 •

edited

Loading

gman0 Feb 17, 2025 •

edited

Loading

gman0 commented Feb 18, 2025 •

edited

Loading