Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btrfs-progs: docs: improve swapfile #618

Closed
wants to merge 1 commit into from
Closed

btrfs-progs: docs: improve swapfile #618

wants to merge 1 commit into from
+26 −11

Conversation

calestyo
Copy link
Contributor

Clarify active vs. inactive swapfile regarding snapshotting and further minor improvements.

Issue: #608

@kdave @calestyo
btrfs-progs: docs: improve swapfile
fa8d383 
Clarify active vs. inactive swapfile regarding snapshotting and further minor
improvements.

Issue: kdave#608
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
@calestyo
Copy link
Contributor Author

Rationale to be found in the comments in:
f9232bb

kdave pushed a commit that referenced this pull request Apr 26, 2023
@calestyo @kdave
btrfs-progs: docs: swapfile clarifications
07efcb2 
Clarify active vs. inactive swapfile regarding snapshotting and further minor
improvements.

Issue: #608
Pull-request: #618
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Signed-off-by: David Sterba <dsterba@suse.com>
@kdave kdave added this to the v6.3 milestone Apr 26, 2023
@kdave
Copy link
Owner

kdave commented Apr 26, 2023

Thanks, applied as a separate commit.

@kdave kdave closed this Apr 26, 2023
@calestyo calestyo deleted the improve-swapfile-documentation branch April 26, 2023 12:28
@calestyo
Copy link
Contributor Author

Thx.

Did you keep the two added the file from your previous 5dd176d on purpose?

I think it would be more consistent without, cause in all other places:

    filesystem - must be only single device
    filesystem - must have only single data profile
    subvolume - cannot be snapshotted if it contains any active swapfiles
    swapfile - the file must be preallocated (i.e. no holes)
    swapfile - the file must be NODATACOW (i.e. also NODATASUM, no compression)

we refer to the object before the -, but for swapfile, we repeat the file

@kdave
Copy link
Owner

kdave commented Apr 26, 2023

I think it would be more consistent without

Reading it again I agree, so 'the file' removed.

kdave pushed a commit that referenced this pull request Apr 26, 2023
@calestyo @kdave
btrfs-progs: docs: swapfile clarifications
321b2f6 
Clarify active vs. inactive swapfile regarding snapshotting and further minor
improvements.

Issue: #608
Pull-request: #618
Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
Signed-off-by: David Sterba <dsterba@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calestyo @kdave