Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandatory node-space before slashdash and children block #499

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Jan 23, 2025

Fix #495

@tabatkins
Copy link
Contributor

Could you drop a test for this?

Copy link
Member

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of interesting tests will be good yeah

@larsgw
Copy link
Contributor Author

larsgw commented Jan 28, 2025

Okay, added.

@bgotink
Copy link
Member

bgotink commented Jan 28, 2025

Test case braces_in_bare_id_fail.kdl becomes valid with this change so it should be updated as well.

It's content

foo123{bar}

is now equivalent to

foo123 { bar }

@larsgw
Copy link
Contributor Author

larsgw commented Jan 28, 2025

Indeed, I forgot to patch that into kdljs while testing. Thank you @bgotink

@tabatkins tabatkins merged commit 84911fe into kdl-org:main Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node space now required before children block
4 participants