Skip to content

Conversation

@rickbrouwer
Copy link
Member

@rickbrouwer rickbrouwer commented Oct 22, 2025

Updated prometheus dependency version to v0.304.2.

Checklist

Fixes #7183

@rickbrouwer rickbrouwer requested a review from a team as a code owner October 22, 2025 08:35
@keda-automation keda-automation requested a review from a team October 22, 2025 08:35
@github-actions
Copy link

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

Updated prometheus dependency version to v0.54.0.

Signed-off-by: Rick Brouwer <[email protected]>
@rickbrouwer
Copy link
Member Author

Unfortunately, I can't see the Snyk report myself. That's why I have ran a snyk test --file=go.mod.

It looks like the vulnerability is in github.com/valyala/fasthttp version 1.51.0.
The secure version is 1.53.0 or later.
It looks like it's caused by indirect dependencies (github.com/dysnix/predictkube-libs/...).

I've created a PR: dysnix/predictkube-libs#49

@rickbrouwer
Copy link
Member Author

rickbrouwer commented Oct 23, 2025

/run-e2e metrics_api
Update: You can check the progress here

@zroubalik
Copy link
Member

zroubalik commented Oct 25, 2025

/run-e2e prometheus
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 21aa12b into kedacore:main Oct 25, 2025
40 of 41 checks passed
@rickbrouwer rickbrouwer deleted the prom branch October 26, 2025 14:03
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 29, 2025
Updated prometheus dependency version to v0.54.0.

Signed-off-by: Rick Brouwer <[email protected]>
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 29, 2025
Updated prometheus dependency version to v0.54.0.

Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
JorTurFer added a commit that referenced this pull request Oct 29, 2025
* Fix incorrect 'unmatched input property' notification (#7176)

* Fix incorrect 'unmatched input property' notification

Signed-off-by: Rick Brouwer <[email protected]>

* Remove redundant parsing

Signed-off-by: Rick Brouwer <[email protected]>

* fix

Signed-off-by: Rick Brouwer <[email protected]>

* use typedconfig once

Signed-off-by: Rick Brouwer <[email protected]>

* static check

Signed-off-by: Rick Brouwer <[email protected]>

* Update test

Signed-off-by: Rick Brouwer <[email protected]>

* Update datadog_scaler_test.go

Signed-off-by: Rick Brouwer <[email protected]>

* update schemas

Signed-off-by: Rick Brouwer <[email protected]>

* fix test

Signed-off-by: Rick Brouwer <[email protected]>

* update typedconfig

Signed-off-by: Rick Brouwer <[email protected]>

* Update pkg/scalers/datadog_scaler.go

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Rick Brouwer <[email protected]>

---------

Signed-off-by: Rick Brouwer <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix: add missing error returns in kafka scaler error handling (#7182)

* fix: add missing error returns in kafka scaler error handling

Add missing error returns after error logging in getTopicPartitions
and getLagForPartition functions to prevent incorrect behavior
when errors occur.

- Add error return in getTopicPartitions when listCGOffsetResponse.Err > 0
- Add error return in getTopicPartitions when topicMetadata.Err > 0
- Add error return in getLagForPartition when block.Err > 0

Previously these functions only logged errors but continued execution,
which could lead to incorrect scaling behavior.

Signed-off-by: leeyeonwoo <[email protected]>

* docs: update changelog for PR #7182

Signed-off-by: leeyeonwoo <[email protected]>

---------

Signed-off-by: leeyeonwoo <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* Fix incorrect 'unmatched input property' notification (#7188)

* Fix incorrect 'unmatched input property' notification

Signed-off-by: Rick Brouwer <[email protected]>

* add azure cloud

Signed-off-by: Rick Brouwer <[email protected]>

* fix

Signed-off-by: Rick Brouwer <[email protected]>

---------

Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix: feature flag for unexpected scaler param check (#7191)

Signed-off-by: Jan Wozniak <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* Update prometheus dependency version (#7194)

Updated prometheus dependency version to v0.54.0.

Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* fix: send raw metrics also during polling interval (#7198)

Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>

* update changelog

Signed-off-by: Jorge Turrado <[email protected]>

* .

Signed-off-by: Jorge Turrado <[email protected]>

* fix changelog

Signed-off-by: Jorge Turrado <[email protected]>

---------

Signed-off-by: Rick Brouwer <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Signed-off-by: leeyeonwoo <[email protected]>
Signed-off-by: Jan Wozniak <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Co-authored-by: Rick Brouwer <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: leeyeonwoo <[email protected]>
Co-authored-by: Jan Wozniak <[email protected]>
Co-authored-by: Zbynek Roubalik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prometheus invalid version: unknown revision 000000000000

3 participants