Add simple demo that sets up the OTEL collector in a pull mode (scrap… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing another metrics endpoints) and sending it to scaler Signed-off-by: Jirka Kremser <[email protected]>
zroubalik
reviewed
Oct 22, 2024
There was a problem hiding this comment.
Should we move this to https://github.com/kedify/examples/tree/main/samples and here just reference, so it is together with the rest of the samples? WDYT?
Comment on lines
+29
to
+30
| ```yaml | ||
| ... |
There was a problem hiding this comment.
Do you really want to have here ``` twice ?
There was a problem hiding this comment.
oh, it's ellipsis (... != ```). It's part of the real values file.
examples/metric-pull/README.md
Outdated
| Prepare helm chart repos: | ||
|
|
||
| ```bash | ||
| helm repo add kedacore https://kedacore.github.io/charts |
There was a problem hiding this comment.
I would prefer if we find a way how to reference here Kedify instead of KEDA
examples/metric-pull/README.md
Outdated
|
|
||
| We set these two annotation in our service for podinfo [here](./podinfo-values.yaml). | ||
|
|
||
| Install KEDA: |
There was a problem hiding this comment.
same as above Kedify reference
| Create some traffic: | ||
| ```bash | ||
| hey -n 5000 -c 4 -q 20 -z 70s http://localhost:8080/delay/2 | ||
| ``` |
There was a problem hiding this comment.
Would be nice to add some conclusion or explanation of what we see
Signed-off-by: Jirka Kremser <[email protected]>
Signed-off-by: Jirka Kremser <[email protected]>
Signed-off-by: Jirka Kremser <[email protected]>
Signed-off-by: Jirka Kremser <[email protected]>
zroubalik
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing another metrics endpoints) and sending it to scaler