Skip to content

garaga-rs: Faster polynomial division. #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024
Merged

garaga-rs: Faster polynomial division. #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc00c40
garaga-rs: Faster polynomial division.
feltroidprime Dec 5, 2024
c650919
upd wasm
feltroidprime Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tools/garaga_rs/src/algebra/polynomial.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ impl<F: IsPrimeField> Polynomial<F> {

Polynomial::new(result_coeffs)
}

pub fn divmod(self, denominator: &Self) -> (Self, Self) {
let den_deg = denominator.degree();
if den_deg == -1 {
Expand All @@ -127,10 +126,9 @@ impl<F: IsPrimeField> Polynomial<F> {
let shift = rem_deg - den_deg;
let coefficient = &remainder.coefficients[rem_deg as usize] * &denom_lead_inv;
quotient_coeffs[shift as usize] = coefficient.clone();

let mut subtractee_coeffs = vec![FieldElement::<F>::zero(); (shift) as usize];
subtractee_coeffs.push(coefficient);
let subtractee = Polynomial::new(subtractee_coeffs).mul_with_ref(denominator);
let subtractee = denominator
.scale_by_coeff(&coefficient)
.shift(shift as usize);
remainder = remainder - subtractee;
rem_deg = remainder.degree();
}
Expand All @@ -139,6 +137,12 @@ impl<F: IsPrimeField> Polynomial<F> {
(quotient, remainder)
}

pub fn shift(&self, shift: usize) -> Self {
let mut shifted_coeffs = vec![FieldElement::<F>::zero(); shift];
shifted_coeffs.extend(self.coefficients.clone());
Self::new(shifted_coeffs)
}

pub fn divfloor(&self, denominator: &Self) -> Self {
let (quotient, _remainder) = self.clone().divmod(denominator);
quotient
Expand Down
2 changes: 1 addition & 1 deletion tools/npm/garaga_ts/src/wasm/pkg/garaga_rs_bg.wasm.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading