Prevent unfocused wheel changes in alternative save method setting - #13358
Open
droidmonkey with Copilot wants to merge 4 commits into
Open
Prevent unfocused wheel changes in alternative save method setting#13358droidmonkey with Copilot wants to merge 4 commits into
droidmonkey with Copilot wants to merge 4 commits into
Conversation
1 task
Agent-Logs-Url: https://github.com/keepassxreboot/keepassxc/sessions/b5c103c7-73ed-44cc-8b9f-bb5d0ce165d4 Co-authored-by: droidmonkey <2809491+droidmonkey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unintended dropdown value changes while scrolling settings
Prevent unfocused wheel changes in alternative save method setting
May 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13358 +/- ##
========================================
Coverage 64.45% 64.45%
========================================
Files 378 378
Lines 39793 39794 +1
========================================
+ Hits 25647 25649 +2
+ Misses 14146 14145 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent accidental changes to the Alternative storage method combobox in the General settings page when the user scrolls with the mouse wheel while the control is not focused, reducing the risk of silently switching to a more dangerous save mode.
Changes:
- Install the existing
MouseWheelEventFilteronalternativeSaveComboBoxinApplicationSettingsWidgetto ignore wheel events when unfocused.
droidmonkey
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling the General settings page could change the Alternative storage method combobox when the cursor passed over it, even if the control was not focused. This could silently switch save behavior to a riskier option.
Behavior change
MouseWheelEventFiltertoalternativeSaveComboBoxinApplicationSettingsWidgetImplementation
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https -Wall -Wextra -Wundef(dns block)https://api.github.com/repos/keepassxreboot/keepassxc/releases/latest/tmp/keepassxc-build/tests/gui/testgui /tmp/keepassxc-build/tests/gui/testgui testSettingsWheelDoesNotChangeAlternativeSaveMethodWithoutFocus -imultiarch x86_64-linux-gnu -MD src/CMakeFiles/keepassxc_gui.dir/keepassxc_gui_autogen/XJKH4KRZSW/qrc_wizard.cpp/home/REDACTED/work/keepassxc/keepassxc/tests/gui/PRIVATE -MF src/CMakeFiles/keepassxc_gui.dir/keepassxc_gui_autogen/XJKH4KRZSW/qrc_wizard.cpp/home/REDACTED/work/keepassxc/keepassxc/src/gui/entry -MT src/CMakeFiles/keepassxc_gui.dir/keepassxc_gui_autogen/XJKH4KRZSW/qrc_wizard.cpp.o -D_GNU_SOURCE -D_REENTRANT /gui�� LIB -DQT_DBUS_LI-DQT_GUI_LIB eEncryption.cpp.-DQT_NETWORK_LIB assxc/src e/keeshare_autogas utogen/include assxc/src arty/zxcvbn(http block)If you need me to access, download, or install something from one of these locations, you can either: