Load tray icon directly on Linux - #13478
Open
hifi wants to merge 1 commit into
Open
Conversation
droidmonkey
approved these changes
Jun 29, 2026
On Wayland specifically it seems that relying on the icon name isn't enough on Qt6 to load the correct icon. It is likely a Qt bug but we can workaround it.
droidmonkey
force-pushed
the
fix/wayland-tray-icon
branch
from
July 1, 2026 03:44
be21f5e to
c81b7f5
Compare
Contributor
Author
|
We discussed that this has the unfortunate side effect of overriding theme based icons, finding and understanding the root cause might be worth doing even if it's a Qt/Plasma bug. |
Member
|
I don't think it's a bug. The icon resolution works if the icons are installed on the system. It fails if they are not, such as when you use the AppImage. In that case, it falls back to the app icon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wayland specifically it seems that relying on the icon name isn't enough on Qt6 to load the correct icon. It is likely a Qt bug but we can workaround it.
I don't know if this is a good approach but if no one knows any better it at least seems to work. Might need to load the colorful icon like this as well for consistency?
Testing strategy
Works fine on Wayland KDE now, this might affect X11 as well but haven't yet tested it, if it does it's likely a Qt6 bug.
Type of change