Skip to content

Fix search + prefix modifier ignoring case sensitivity #13493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abdosaeedelhassan wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −0
Open

Fix search + prefix modifier ignoring case sensitivity #13493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/EntrySearcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ void EntrySearcher::parseSearchTerms(const QString& searchString)
}
if (mods.contains("+")) {
opts |= Tools::RegexConvertOpts::EXACT_MATCH;
opts |= Tools::RegexConvertOpts::CASE_SENSITIVE;
}
term.regex = Tools::convertToRegex(term.word, opts);

Expand Down
10 changes: 10 additions & 0 deletions tests/TestEntrySearcher.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,16 @@ void TestEntrySearcher::testSearch()
m_searchResult = m_entrySearcher.search("+user:email", m_rootGroup);
QCOMPARE(m_searchResult.count(), 0);

// Test that + modifier enforces case sensitivity
m_searchResult = m_entrySearcher.search("+password:testpass", m_rootGroup);
QCOMPARE(m_searchResult.count(), 1);

m_searchResult = m_entrySearcher.search("+password:Testpass", m_rootGroup);
QCOMPARE(m_searchResult.count(), 0);

m_searchResult = m_entrySearcher.search("+password:TestPass", m_rootGroup);
QCOMPARE(m_searchResult.count(), 0);

// Terms are logical AND together
m_searchResult = m_entrySearcher.search("password:pass user:user", m_rootGroup);
QCOMPARE(m_searchResult.count(), 1);
Expand Down