Skip to content

Conversation

diegovb-sys
Copy link
Contributor

Closes #5340

📑 Description

As I've posted in the Issue. There are some scenarios, where specific alert fields can be casted to other type than the expected.
An example is to use Mapping to dismiss an alert and after of that, read that field in a WF. The WF would expect a boolean value, but it will received a string, so this will cause a celpy error.

In order to face that problem, I've implemented (inside the Except) in WF and Incidents scopes a cast to the original values. (Using the ones defined in AlertDTO)

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Oct 2, 2025

@diegovb-sys is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Bug Something isn't working labels Oct 2, 2025
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 2.56410% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.47%. Comparing base (57ca737) to head (3fb3b56).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
keep/rulesengine/rulesengine.py 4.16% 23 Missing ⚠️
keep/workflowmanager/workflowmanager.py 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5347       +/-   ##
===========================================
- Coverage   46.64%   30.47%   -16.18%     
===========================================
  Files         175      101       -74     
  Lines       18263    11700     -6563     
===========================================
- Hits         8519     3565     -4954     
+ Misses       9744     8135     -1609     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Enrichments vs CEL comparison

1 participant