fix: register all missing message types in transport typeRegistry#35
Merged
BitHighlander merged 1 commit intomasterfrom Mar 30, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Binance, Ethereum, Osmosis, Solana, Tendermint, TON, and TRON proto message classes were missing from typeRegistry, causing "Unknown message type received" errors when the device sent responses for these chains.
BitHighlander
force-pushed
the
fix/type-registry-all-chains-clean
branch
from
dd5ff99 to
6d1e5c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typeRegistry.ts: Binance, Ethereum, Osmosis, Solana, Tendermint, TON, TRONOsmosisAddress,BinanceAddress)messages-*_pbmodules from@keepkey/device-protocolare now registeredRoot Cause
typeRegistry.tsmapsMessageTypeenum values to their protobuf constructors. When a chain's message module isn't registered, the transport can't deserialize the device response and throws "Unknown message type received".Test plan
tsc --noEmitpassesyarn buildpasses (1.77s)getAddressno longer returns "Unknown message type received"