chore: update submodules + nanopb options for 7.14.0 proto chains#383
Open
BitHighlander wants to merge 1 commit intodevelopfrom
Open
chore: update submodules + nanopb options for 7.14.0 proto chains#383BitHighlander wants to merge 1 commit intodevelopfrom
BitHighlander wants to merge 1 commit intodevelopfrom
Conversation
BitHighlander
force-pushed
the
chore/7.14.0-transport-prep
branch
from
1db91da to
0e3b23d
Compare
- Point device-protocol and python-keepkey submodules to upstream master (includes BIP-85, Solana, Tron, TON wire IDs and proto definitions) - Add nanopb .options files for Solana, Tron, TON (field size constraints) - Add Bip85Mnemonic.mnemonic max_size:241 to messages.options - Update lib/transport/CMakeLists.txt with new proto sources, options, headers, and protoc compilation commands - Fix CI: use pre-installed clang-format instead of apt-get install (eliminates 3-minute timeout on GitHub runners) - Update Zcash transparent branch ID from Sapling to NU6
BitHighlander
force-pushed
the
chore/7.14.0-transport-prep
branch
from
0e3b23d to
b6db24d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The device-protocol and python-keepkey submodules on develop predate the 7.14.0 wire definitions (BIP-85, Solana, Tron, TON). Without updating these pointers and adding corresponding nanopb
.optionsfiles, any branch that introduces these chains will fail thepb_callback_tforbidden check during proto compilation.This PR is a prerequisite for all 7.14.0 feature PRs.
Changes
Submodule updates:
deps/device-protocol→ upstream master (includes BIP-85 wire ID 120-121, Solana 750-755, Tron 1400-1403, TON 1500-1503)deps/python-keepkey→ upstream master (includes proto bindings + integration test scaffolding for all new chains)Nanopb options (new files):
messages-solana.options— field size constraints for SolanaGetAddress, SolanaSignTx, SolanaSignMessage, SolanaMessageSignaturemessages-tron.options— field size constraints for TronGetAddress, TronSignTxmessages-ton.options— field size constraints for TonGetAddress, TonSignTxmessages.options— addBip85Mnemonic.mnemonic max_size:241Transport CMakeLists:
CI fix:
apt-get install clang-format-14(36MB download, causes 3-min timeout) with pre-installedclang-formaton ubuntu-latest runnersZcash NU6:
0x892f2085) to NU6 insigning.cRisk assessment
Low risk. No firmware logic changes — only build infrastructure, submodule pointers, and proto field constraints. The nanopb options are strictly additive (new files for new protos). Existing chain compilation is unchanged.
Testing
requires_firmware("7.14.0"))