feat: add Gnosis chain + fix zcash-shielded balance routing#65
Open
BitHighlander wants to merge 1 commit intodevelopfrom
Open
feat: add Gnosis chain + fix zcash-shielded balance routing#65BitHighlander wants to merge 1 commit intodevelopfrom
BitHighlander wants to merge 1 commit intodevelopfrom
Conversation
- Add Gnosis (xDAI, eip155:100) as default EVM chain with CAIP fallbacks - Skip hidden chains in getBalances address derivation loop (fixes zcash-shielded calling wallet.zcashGetOrchardFvk which doesn't exist) - Prioritize non-hidden chains in networkToChain map so zcash transparent wins over zcash-shielded for the shared networkId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hiddenchains in getBalances address derivation loop — zcash-shielded was callingwallet.zcashGetOrchardFvk()which doesn't exist on the hdwallet objectnetworkToChainmap — both zcash and zcash-shielded share the same networkId, and zcash-shielded was overwriting zcash's entryTest plan
[getBalances] Zcash address failederror is gone from logsnetworkToChainmap showszcash(notzcash-shielded) forbip122:00040fe8ec8471911baa1db1266ea15d