fix: clear stale keyring to prevent USB reconnect flapping#66
Open
BitHighlander wants to merge 2 commits intodevelopfrom
Open
fix: clear stale keyring to prevent USB reconnect flapping#66BitHighlander wants to merge 2 commits intodevelopfrom
BitHighlander wants to merge 2 commits intodevelopfrom
Conversation
…ping When initializeWallet() is called on retry, the keyring may still hold a transport from the previous failed attempt with usbDevice.opened=true. WebUSB rejects with "cannot connect an already-connected connection" and the device loops between connected_unpaired retries until a physical detach/attach cycle resets the state. Call keyring.removeAll() at the top of initializeWallet() to close any stale transports before attempting to pair.
LIBUSB_TRANSFER_ERROR from a previous session persisted in the setup wizard error banner after disconnect/reconnect. Clear setupError when device state transitions to needs_init or ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializeWallet()doesn't clear the keyring before retrying, so the previous failed attempt's transport still hasusbDevice.opened = truekeyring.removeAll()at the top ofinitializeWallet()to close stale transports before pairingTest plan