Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to object-oriented design #42

Closed
wants to merge 297 commits into from
Closed

Conversation

devin-ai-integration[bot]
Copy link

@devin-ai-integration devin-ai-integration bot commented Jan 17, 2025

Link to Devin run: https://app.devin.ai/sessions/61d26f9060ba40b6bb4708de40fa4e5c

This PR focuses on refactoring the codebase to improve modularity and maintainability through object-oriented design:

Key Changes:

  1. Introduced core classes:

    • MSMDSystemGenerator for system creation
    • ProbabilityMap for probability map handling
    • Configuration for settings management
    • GridUtils for grid operations
    • ResidueEnvironmentAnalyzer for residue analysis
  2. Improved code organization:

    • Moved related functionality into cohesive classes
    • Added proper type hints
    • Maintained backward compatibility through wrapper functions
  3. Enhanced maintainability:

    • Reduced code duplication
    • Improved code readability
    • Better separation of concerns

Note: Test infrastructure improvements have been moved to a separate PR (#43) for cleaner review process.

keisuke-yanagisawa and others added 24 commits May 17, 2024 16:12
Enabling to use MPS (Multi-Process Service) for better calculation efficiency
Refactor Default Value Handling in Configuration Files
… Update .gitignore to track config files.

Co-Authored-By: K. Yanagisawa <[email protected]>
- Add TypedDict classes for settings and configuration
- Add type hints to function signatures in core modules
- Fix type compatibility issues in dictionary operations
- Improve docstring formatting for better type checking
- Add numpy typing for array operations

Co-Authored-By: K. Yanagisawa <[email protected]>
- Add .coveragerc with source and report settings
- Update CI workflow to run coverage with pytest
- Add coverage output files to .gitignore

Co-Authored-By: K. Yanagisawa <[email protected]>
…bilityMap, MDSimulationManager, ResidueEnvironmentAnalyzer, Configuration, and ProfileAnalyzer with backward compatibility

Co-Authored-By: K. Yanagisawa <[email protected]>
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot changed the title Code Refactor to OOP Refactor code to object-oriented design Jan 17, 2025
- Remove test infrastructure changes
- Test infrastructure moved to enhance_unittest branch

Co-Authored-By: K. Yanagisawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants