self-development: migrate bodyContains to bodyPattern in spawner configs#1127
Merged
Conversation
The bodyContains field is deprecated in favor of bodyPattern. Swap all 10 filter entries across the 6 webhook-driven self-development TaskSpawners so contributors copying these manifests as templates do not propagate deprecated API usage. The literal command strings (/kelos pick-up, /kelos plan, /kelos review, /kelos api-review, /kelos squash-commits) contain no Go re2 metacharacters, so the substring-match semantics are preserved. Co-Authored-By: Claude Opus 4.7 <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
kelos-bot[bot] has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
github-actions
Bot
added
kind/cleanup
needs-triage
needs-priority
needs-actor
release-note-none
labels
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
All 6 webhook-driven TaskSpawners under
self-development/still use the deprecatedbodyContainsfield in their webhook filters. The Kelos API declares this field deprecated in favor ofbodyPattern(api/v1alpha1/taskspawner_types.go:435-438), and the user-facing docs/examples are already being migrated (PR #1119). The self-development files — which contributors read as canonical reference TaskSpawners — had been left out of that scope.This PR swaps all 10
bodyContains: <literal>entries across the 6 spawners tobodyPattern: <literal>:kelos-workers.yamlkelos-pr-responder.yamlkelos-planner.yamlkelos-reviewer.yamlkelos-api-reviewer.yamlkelos-squash-commits.yamlThe literal command strings (
/kelos pick-up,/kelos plan,/kelos review,/kelos api-review,/kelos squash-commits) contain no Go re2 metacharacters, so substring-match behavior is preserved exactly.Which issue(s) this PR is related to:
Fixes #1125
Special notes for your reviewer:
Out of scope (per the issue):
^/kelos ...— would change semantics.excludeBodyPatternsto filter quoted-comment matches.README.mdexample snippet — kept aligned with the issue's enumerated*.yamlscope.Verification:
grep -c bodyContains self-development/*.yamlnow returns0for all files.Does this PR introduce a user-facing change?
Summary by cubic
Replaced deprecated
bodyContainswithbodyPatternin all self-development TaskSpawner webhook filters to align with the Kelos API. Addresses #1125; behavior is unchanged since the command strings are literal (no re2 metacharacters).Written for commit 76c6db8. Summary will update on new commits.