fix watch mode --fix with multiple files #353
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a problem, where toggling
--fix
via the watch plugin worked fine when I filtered the list of files to 1 file. As soon as I started watching multiple files, however,--fix
did not work anymore.It took me quite a while to figure this out, but it looks like somehow this way of creating the runner
leads to a situation where the import for
configOverrides
inrun.js
creates new objects for each file the runner is run on. Since this object is not the same as the one imported in the watch plugin itself,.getFix()
always returned undefined, and the fix never worked.The change in here fixes that, because
configOverrides
is only imported once inindex.js
.This approach is actually taken from
jest-runner-eslint
, which worked fine for me.