Refactor: Use embedding.EmbeddingVariables in Keras-RS JAX embedding tests.

[manuadg-google]

This change updates the Keras-RS JAX embedding tests to use the embedding.EmbeddingVariables dataclass from jax_tpu_embedding for representing embedding tables and slot variables, instead of a custom tuple structure. This involves updating type hints, variable access, and build dependencies.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @manuadg-google, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the Keras-RS JAX embedding tests by standardizing the way embedding tables and their slot variables are handled. The core change involves replacing ad-hoc tuple structures with the more explicit and robust embedding.EmbeddingVariables dataclass. This modernization aims to improve the overall readability, maintainability, and type-checking capabilities of the test suite, making the code easier to understand and work with for future development and debugging.

Highlights

• Refactored Embedding Variable Representation: The pull request transitions from using custom tuple structures to the embedding.EmbeddingVariables dataclass for representing embedding tables and their associated slot variables within the Keras-RS JAX embedding tests.
• Improved Type Safety and Readability: Type hints and variable access patterns have been updated to leverage the structured EmbeddingVariables dataclass, enhancing code clarity, maintainability, and type safety across the affected test utilities.
• Dependency and Import Updates: The necessary embedding module from jax_tpu_embedding.sparsecore.lib.nn has been imported to support the new dataclass, alongside minor import reordering.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Keras-RS JAX embedding tests to use the embedding.EmbeddingVariables dataclass. The changes are well-executed, replacing custom tuple structures with the dataclass, which improves code clarity and maintainability by using named attributes instead of indexing. The type hints have been updated accordingly throughout the test files. I've found a couple of minor issues: an unused import was added, and there's an opportunity to improve readability by using named attribute access instead of indexing in one place. Both are small fixes to improve code quality.