Skip to content

Conversation

hertschuh
Copy link
Collaborator

Passing __jax_array__-implementing objects directly to jax.jit will no longer be supported.

Passing `__jax_array__`-implementing objects directly to `jax.jit` will no longer be supported.
Copy link

Summary of Changes

Hello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical compatibility update for JAX, preventing potential breakage in JIT-compiled code. By proactively unwrapping specific variable types, the changes ensure that Keras-RS components continue to function seamlessly with future versions of JAX, maintaining the stability and performance of the system.

Highlights

  • JAX Compatibility Update: This pull request updates the codebase to align with an upcoming change in JAX where __jax_array__-implementing objects will no longer be directly supported when passed to jax.jit.
  • Variable Unwrapping: The change explicitly unwraps trainable_variables and non_trainable_variables by accessing their .value attribute before they are passed to a JIT-compiled function, ensuring proper handling by JAX.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an upcoming breaking change in JAX by explicitly unwrapping Keras variables to their underlying arrays before passing them to jax.jit. The modification within the test suite is implemented cleanly using list comprehensions. The change is correct and well-contained. I have no further suggestions.

@hertschuh hertschuh requested a review from cantonios September 26, 2025 20:13
@hertschuh hertschuh merged commit 6ca4b4f into keras-team:main Sep 26, 2025
5 checks passed
@hertschuh hertschuh deleted the jax_array branch September 26, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants