Update oracle_client.py to enable_http_proxy#981
Open
pbk0 wants to merge 1 commit intokeras-team:masterfrom
Open
Update oracle_client.py to enable_http_proxy#981pbk0 wants to merge 1 commit intokeras-team:masterfrom
pbk0 wants to merge 1 commit intokeras-team:masterfrom
Conversation
Line 35 anyway makes an insecure channel and expects that users are on a safe network. But it still uses https proxies and some corporate environments try to block it (as in my case). So adding the second line instead of the first worked in my case.
``` python
channel = grpc.insecure_channel(f"{ip_addr}:{port}")
channel = grpc.insecure_channel(f"{ip_addr}:{port}", options=(('grpc.enable_http_proxy', 0),))
```
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #981 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 50 50
Lines 3085 3085
=======================================
Hits 3035 3035
Misses 50 50 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 35 anyway makes an insecure channel and expects that users are on a safe network. But it still uses https urls and some corporate environments try to verify certificates (as in my case) and it breaks. So adding the second line instead of the first worked in my case and ends up using http links.