-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Fix misleading documentation for smart_resize backend_module parameter #21722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Flakes342, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request clarifies the documentation for the backend_module
parameter in smart_resize
to indicate it's for internal use and shouldn't be used to switch backends. This is a helpful change to prevent user confusion. However, the implementation has a small but critical issue where the argument name backend_module:
is removed from the docstring, which will likely break documentation generation. I've added a comment with a suggestion to fix this.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21722 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 572 572
Lines 58401 58401
Branches 9146 9146
=======================================
Hits 48238 48238
Misses 7828 7828
Partials 2335 2335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Clarifies the
backend_module
parameter documentation in smart_resize() to prevent user confusion.Changes
Updated the docstring for the backend_module parameter to clarify:
Motivation
Fixes issue #21711 where users attempt to pass keras.backend or other modules, resulting in AttributeError. The current documentation suggests this parameter offers more flexibility than it actually provides.
Current documentation & proposed change:
Proposed change:
Testing