-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Fix ModelParallel OOM issue during weight loading #21723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amitsrivastava78
wants to merge
10
commits into
keras-team:master
Choose a base branch
from
amitsrivastava78:pytorch-fix-rebased
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
eda5176
Fix ModelParallel OOM issue during weight loading
amitsrivastava78 5da9108
Fix PyTorch backend tensor conversion and refactor variable loading
amitsrivastava78 9886e40
Optimize JAX backend variable initialization and memory management
amitsrivastava78 92bf1ed
Remove JAX reference-holding functionality and related tests
amitsrivastava78 250c19c
Remove quantization/saving changes that conflict with PR #21713
amitsrivastava78 6e222c9
Remove remaining variable_loading imports and use inline code
amitsrivastava78 6197d21
Revert embedding.py quantization logic while preserving _direct_assig…
amitsrivastava78 cfc95da
Fix Dense and EinsumDense layers to use _direct_assign for consistency
amitsrivastava78 0f02b80
Update all layer load_own_variables methods to use _direct_assign
amitsrivastava78 2bb83c6
Add shape validation to layer load_own_variables methods for consiste…
amitsrivastava78 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this was not needed before?
Line 27 should make it work.
Under what circumstances did you need this?