Skip to content

use dependency injected value and methods, rather than directly from library #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kernelshard merged 2 commits into from
Aug 11, 2025
Merged

use dependency injected value and methods, rather than directly from library #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
390084f
feat: refactor a bit
kernelshard Aug 9, 2025
55150a3
fix main, provided concurrency limit
kernelshard Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion services/url/cmd/url/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ func main() {
notificationProducer.Start(ctx)

httpClient := &http.Client{Timeout: 5 * time.Second}
chkr := checker.NewURLChecker(urlSvc, l, httpClient, 1*time.Minute, notificationProducer, tracer)
concurrencyLimit := 10
chkr := checker.NewURLChecker(urlSvc, l, httpClient, 1*time.Minute, notificationProducer, tracer, concurrencyLimit)
go chkr.Start(ctx)

urlHandler := handler.NewURLHandler(urlSvc, l)
Expand Down
13 changes: 9 additions & 4 deletions services/url/internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ type URLChecker struct {
interval time.Duration
notificationProducer kafka.NotificationProducer
tracer *tracing.Tracer
concurrencyLimit int
httpTimeOut time.Duration
}

func NewURLChecker(
Expand All @@ -37,6 +39,7 @@ func NewURLChecker(
interval time.Duration,
producer kafka.NotificationProducer,
tracer *tracing.Tracer,
concurrencyLimit int,
) *URLChecker {
if producer == nil {
// This panic indicates a serious configuration error that should be caught
Expand All @@ -52,6 +55,7 @@ func NewURLChecker(
interval: interval,
notificationProducer: producer,
tracer: tracer,
concurrencyLimit: concurrencyLimit,
}
}

Expand Down Expand Up @@ -79,12 +83,13 @@ func (uc *URLChecker) CheckAllURLs(ctx context.Context) {
urls, err := uc.svc.GetAll(ctx)
if err != nil {
uc.logger.Error("Failed to fetch URLs", slog.Any("error", err))
span.RecordError(err)
uc.tracer.RecordError(span, err)
return
}

var wg sync.WaitGroup
sem := make(chan struct{}, 10) // Limit to 10 concurrent checks
// Use the configurable concurrency limit for the semaphore.
sem := make(chan struct{}, uc.concurrencyLimit)

for _, url := range urls {
wg.Add(1)
Expand Down Expand Up @@ -114,7 +119,7 @@ func (uc *URLChecker) CheckAllURLs(ctx context.Context) {
slog.String("status", status),
slog.Any("error", err),
)
span.RecordError(err)
uc.tracer.RecordError(span, err)
} else {
uc.logger.Info("URL status updated",
slog.String("urlID", url.ID),
Expand All @@ -135,7 +140,7 @@ func (uc *URLChecker) CheckAllURLs(ctx context.Context) {
uc.logger.Error("Failed to publish notification",
slog.String("url_id", url.ID),
slog.Any("error", err))
span.RecordError(err)
uc.tracer.RecordError(span, err)
}
}
}
Expand Down
Loading