fix(core): no longer lowercasing PluginClassIdentifier to have proper…

… validation upon Plugin deserialization closes #7387
kestra-io · Feb 28, 2025 · 17e5413 · 17e5413
1 parent cacbd06
commit 17e5413
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/core/src/main/java/io/kestra/core/plugins/DefaultPluginRegistry.java b/core/src/main/java/io/kestra/core/plugins/DefaultPluginRegistry.java
@@ -217,7 +217,7 @@ public static ClassTypeIdentifier create(final String identifier) {
             if (identifier == null || identifier.isBlank()) {
                 throw new IllegalArgumentException("Cannot create plugin identifier from null or empty string");
             }
-            return new ClassTypeIdentifier(identifier.toLowerCase(Locale.ROOT));
+            return new ClassTypeIdentifier(identifier);
         }
 
         /**

diff --git a/core/src/test/java/io/kestra/core/plugins/ClassTypeIdentifierTest.java b/core/src/test/java/io/kestra/core/plugins/ClassTypeIdentifierTest.java
@@ -0,0 +1,17 @@
+package io.kestra.core.plugins;
+
+import org.junit.jupiter.api.Test;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.is;
+
+public class ClassTypeIdentifierTest {
+    @Test
+    void caseMatters() {
+        String identifier = "io.kestra.core.plugins.serdes.PluginDeserializerTest.TestPlugin";
+        assertThat(
+            DefaultPluginRegistry.ClassTypeIdentifier.create(identifier).type(),
+            is(identifier)
+        );
+    }
+}