Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to save bad flow which runs idefinitely #7387

Closed
paulgrainger85 opened this issue Feb 13, 2025 · 2 comments · Fixed by #7622
Closed

Possible to save bad flow which runs idefinitely #7387

paulgrainger85 opened this issue Feb 13, 2025 · 2 comments · Fixed by #7622
Assignees
Labels
area/backend Needs backend code changes bug Something isn't working kind/customer-request Requested by one or more customers

Comments

@paulgrainger85
Copy link

paulgrainger85 commented Feb 13, 2025

Describe the issue

Consider the parent and subflow below. Notice that the type is incorrect, it should be Subflow, not subflow. Kestra UI allows us to save this flow.

id: parent
namespace: abc

tasks:
  - id: hello
    type: io.kestra.plugin.core.flow.subflow
    flowId: child
    namespace: abc
-------
id: child
namespace: abc

tasks:
  - id: hello
    type: io.kestra.plugin.core.log.Log
    message: Hello World! 🚀

The subflow is executed correctly, but the parent flow remains running indefinitely (until manually killed).

What should be the correct behavior here? (stop flow from being saved in the first place, or allow case-insensitive type definition)

Image

Environment

  • Kestra Version: 0.21.2
@paulgrainger85 paulgrainger85 added area/backend Needs backend code changes bug Something isn't working kind/customer-request Requested by one or more customers labels Feb 13, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Feb 13, 2025
@anna-geller
Copy link
Member

anna-geller commented Feb 14, 2025

I'd say we should stop the flow from being saved in the first place here

thx for the report, makes sense!

image
image

@yuri1969
Copy link
Contributor

The root cause seems to be the lowercasing of plugin's canonical name introduced by: 929ee7b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes bug Something isn't working kind/customer-request Requested by one or more customers
Projects
Status: Done
4 participants