Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): prevent dashboard collapse when docks are opened #6719

Conversation

sampath24-ss
Copy link
Contributor

What changes are being made and why?


This PR addresses issue #6688, where opened docks collapse dashboards. The issue has been fixed by ensuring that the opened docks do not interfere with or collapse the dashboard, improving the overall user experience and layout stability.

How the changes have been QAed?

Load the Dashboard Page:

  • Open the page that contains the dashboard.vue component.

Open and Close the Docks:

  • Open and close the docks on the page.

Verify Dashboard Layout:

  • Ensure that the dashboard layout does not collapse or shift when the docks are opened or closed.
  • Verify that the dashboard content remains intact and stable.

Setup Instructions

No additional setup required

@MilosPaunovic MilosPaunovic self-requested a review January 11, 2025 15:45
@MilosPaunovic MilosPaunovic self-assigned this Jan 11, 2025
Copy link
Member

@MilosPaunovic MilosPaunovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not quite what we want.

image

We are trying to achieve that, if the right sidebar is opened, and the main container space is smaller, for the cards to expand to 100% of the width.

@sampath24-ss Can you try to amend that?

@sampath24-ss
Copy link
Contributor Author

This is not quite what we want.

image

We are trying to achieve that, if the right sidebar is opened, and the main container space is smaller, for the cards to expand to 100% of the width.

@sampath24-ss Can you try to amend that?

So it has to be the same size of execution?

@MilosPaunovic
Copy link
Member

Yes, to expand fully to the available space.

@sampath24-ss
Copy link
Contributor Author

Yes, to expand fully to the available space.

Ok got it i will check on it and provide an update @MilosPaunovic

@MilosPaunovic MilosPaunovic removed their assignment Jan 16, 2025
@sampath24-ss
Copy link
Contributor Author

sampath24-ss commented Jan 16, 2025

Yes, to expand fully to the available space.

Ok got it i will check on it and provide an update @MilosPaunovic

Hi @MilosPaunovic ,

I tried all the ways to fix it but i could'nt able to get the max width of the components but made this changes if this is good i can make a PR:
image

@MilosPaunovic
Copy link
Member

Yeah, push those changes to this PR and we'll see how it looks.

@sampath24-ss
Copy link
Contributor Author

Yeah, push those changes to this PR and we'll see how it looks.

Check the PR:#6802

@MilosPaunovic
Copy link
Member

Okay, as you've opened another PR, I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants