Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent filter feature #7276

Merged

Conversation

HarshitDhaduk
Copy link
Contributor

Used el-tag component from element-plus to make a custom tag renderer to disable close functionality (clossable tag) when a single namespace page is selected.

This is the custom-tag renderer component:

        <template #tag="{current}">
            <el-tag
                :disable-transitions="true"
                :closable="!current?.persistent" 
                @close="() => removeItem(current)"
            >
                <Label :option="current" /> 
            </el-tag>
        </template>

In removeItem function, If value passed is persistent=true. The function will return null without removing any item.

@MilosPaunovic MilosPaunovic self-requested a review February 10, 2025 10:46
@HarshitDhaduk HarshitDhaduk force-pushed the persistent-filter-feature branch from 63330f8 to 5f0f7f9 Compare February 10, 2025 10:48
@Skraye Skraye force-pushed the develop branch 2 times, most recently from 320a3a3 to be30034 Compare February 13, 2025 10:20
@MilosPaunovic MilosPaunovic merged commit 3bbe656 into kestra-io:develop Feb 27, 2025
@MilosPaunovic
Copy link
Member

I've made some changes in your approach @HarshitDhaduk, but you've made very good base. Thanks for the contribution! 🚀

Just a small note for the future, if you could use GitHub Keywords when opening PRs to connect it to the proper issue (to automate the entire process a bit more), it would be super helpful to us. You can read a bit more about it here (I've added closing keyword for this particular issue).

@HarshitDhaduk HarshitDhaduk deleted the persistent-filter-feature branch February 27, 2025 09:12
@HarshitDhaduk
Copy link
Contributor Author

Thank you for the inputs @MilosPaunovic. Since this was my first PR, I am not familiar with the guidelines for contribution. Will certainly remember this next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants