Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): move run context property validation to the run context #7414

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

loicmathieu
Copy link
Member

This would avoid loading the Validator from the application context each time we render a property

This would avoid loading the Validator from the application context each time we render a property
Copy link

codecov bot commented Feb 14, 2025

❌ 72 Tests Failed:

Tests completed Failed Passed Skipped
1396 72 1324 13
View the top 3 failed test(s) by shortest run time
io.kestra.plugin.core.http.DownloadTest contentDispositionWithPath()
Stack Traces | 0.001s run time
java.lang.NullPointerException: Cannot invoke "jakarta.validation.Validator.validate(Object, java.lang.Class[])" because "<local3>.validator" is null
	at io.kestra.core.runners.DefaultRunContext.validate(DefaultRunContext.java:319)
	at io.kestra.core.runners.RunContextProperty.validate(RunContextProperty.java:40)
	at io.kestra.core.runners.RunContextProperty.as(RunContextProperty.java:61)
	at io.kestra.plugin.core.http.Download.run(Download.java:69)
	at io.kestra.plugin.core.http.DownloadTest.contentDispositionWithPath(DownloadTest.java:175)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:142)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:162)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:119)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:129)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
io.kestra.plugin.core.http.DownloadTest run()
Stack Traces | 0.001s run time
java.lang.NullPointerException: Cannot invoke "jakarta.validation.Validator.validate(Object, java.lang.Class[])" because "<local3>.validator" is null
	at io.kestra.core.runners.DefaultRunContext.validate(DefaultRunContext.java:319)
	at io.kestra.core.runners.RunContextProperty.validate(RunContextProperty.java:40)
	at io.kestra.core.runners.RunContextProperty.as(RunContextProperty.java:61)
	at io.kestra.plugin.core.http.Download.run(Download.java:69)
	at io.kestra.plugin.core.http.DownloadTest.run(DownloadTest.java:56)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:142)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:162)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:119)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:129)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
io.kestra.plugin.core.state.StateTest getThrow()
Stack Traces | 0.001s run time
org.opentest4j.AssertionFailedError: Unexpected exception type thrown, expected: <java.io.FileNotFoundException> but was: <java.lang.NullPointerException>
	at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:67)
	at app//org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:35)
	at app//org.junit.jupiter.api.Assertions.assertThrows(Assertions.java:3115)
	at app//io.kestra.plugin.core.state.StateTest.getThrow(StateTest.java:122)
	at java.base@21.0.6/java.lang.reflect.Method.invoke(Method.java:580)
	at app//io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:142)
	at app//io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:162)
	at app//io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:119)
	at app//io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:129)
	at java.base@21.0.6/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base@21.0.6/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.NullPointerException: Cannot invoke "jakarta.validation.Validator.validate(Object, java.lang.Class[])" because "<local3>.validator" is null
	at io.kestra.core.runners.DefaultRunContext.validate(DefaultRunContext.java:319)
	at io.kestra.core.runners.RunContextProperty.validate(RunContextProperty.java:40)
	at io.kestra.core.runners.RunContextProperty.as(RunContextProperty.java:61)
	at io.kestra.plugin.core.state.AbstractState.get(AbstractState.java:56)
	at io.kestra.plugin.core.state.Get.run(Get.java:57)
	at io.kestra.plugin.core.state.StateTest.lambda$getThrow$1(StateTest.java:123)
	at org.junit.jupiter.api.AssertThrows.assertThrows(AssertThrows.java:53)
	... 10 more

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To review
Development

Successfully merging this pull request may close these issues.

1 participant