-
Notifications
You must be signed in to change notification settings - Fork 24
feat(plugin-aws): Added the new ubiquitous from in Publish.java closes #12354 #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Pavalasri, thanks for the contribution! 🚀
Seems, there's a compilation error, could you fix that please?
Once you've made the changes, you can run ./gradlew shadowJar locally, to check if the build is successful!
|
Hi @Malaydewangan09 👋 |
|
But it came BUILD SUCCESSFUL when i ran locally! Will recheck it. |
|
No, worries the build is fine, now the tests are failing for the above tasks. |
|
I'll look into it! |
Add error handling for JSON parsing in Publish class.
Add error handling for JSON parsing in Publish.java
|
Hey @Pavalasri 👋, are there any updates on this? Seems CI is sill failing. |
|
Hii @Malaydewangan09 I am trying to solve the issue but couldn't able to find the problem. If possible, can you guide me! |
|
Sure @Pavalasri, you can take a look at this example, which is quite similar to changes you need to do! |
closes kestra-io/kestra#12354
Summary
This PR refactors the plugin-aws to use the new Data.From interface for unified message input handling.
Affected Files
Publish.java → replaced manual parsing logic for from with Data.from(from).read(runContext).
Changes
Implemented the Data.From interface in Publish.
Simplified input reading by removing manual checks for String, List, and URI types.
Now reads all message sources (map, list, or file) through the common Data.from abstraction.
Notes
No changes to message publishing behavior — only cleaner, standardized data input handling.