Skip to content

Conversation

@Pavalasri
Copy link

closes kestra-io/kestra#12354

Summary

This PR refactors the plugin-aws to use the new Data.From interface for unified message input handling.

Affected Files

Publish.java → replaced manual parsing logic for from with Data.from(from).read(runContext).

Changes

Implemented the Data.From interface in Publish.

Simplified input reading by removing manual checks for String, List, and URI types.

Now reads all message sources (map, list, or file) through the common Data.from abstraction.

Notes

No changes to message publishing behavior — only cleaner, standardized data input handling.

@github-project-automation github-project-automation bot moved this to To review in Pull Requests Oct 27, 2025
@MilosPaunovic MilosPaunovic added kind/external Pull requests raised by community contributors area/plugin Plugin-related issue or feature request labels Oct 28, 2025
@MilosPaunovic MilosPaunovic requested review from a team and Malaydewangan09 October 28, 2025 06:39
Copy link
Member

@Malaydewangan09 Malaydewangan09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Pavalasri, thanks for the contribution! 🚀
Seems, there's a compilation error, could you fix that please?
Once you've made the changes, you can run ./gradlew shadowJar locally, to check if the build is successful!

@Pavalasri
Copy link
Author

Pavalasri commented Oct 28, 2025

Hi @Malaydewangan09 👋
I ran ./gradlew shadowJar locally to verify the build — it completed successfully without any errors. Can you check it once!

@Pavalasri
Copy link
Author

But it came BUILD SUCCESSFUL when i ran locally!

Will recheck it.

@Malaydewangan09
Copy link
Member

Malaydewangan09 commented Oct 28, 2025

No, worries the build is fine, now the tests are failing for the above tasks.
You could check by running ./gradlew test or simply just run sns/sqs tests where you did changes!

@Pavalasri
Copy link
Author

I'll look into it!

@Malaydewangan09
Copy link
Member

Hey @Pavalasri 👋, are there any updates on this? Seems CI is sill failing.

@Pavalasri
Copy link
Author

Hii @Malaydewangan09

I am trying to solve the issue but couldn't able to find the problem. If possible, can you guide me!

@Malaydewangan09
Copy link
Member

Sure @Pavalasri, you can take a look at this example, which is quite similar to changes you need to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/plugin Plugin-related issue or feature request kind/external Pull requests raised by community contributors

Projects

Status: To review

Development

Successfully merging this pull request may close these issues.

plugin-aws

3 participants