Skip to content

Eval only and batch normalization #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Eval only and batch normalization #2

wants to merge 9 commits into from

Conversation

kevinmicha
Copy link
Owner

In this PR:

  • Boolean parametersbn (batch normalization) and exact_recon are added to the U-net submission script exact_recon_unet_training.py.
  • An evaluation only submission script eval_only_unet_training.py is created.

@kevinmicha kevinmicha requested a review from zaccharieramzi May 17, 2021 07:32
zaccharieramzi
zaccharieramzi requested changes May 17, 2021
View reviewed changes
Copy link
Collaborator

@zaccharieramzi zaccharieramzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to make the number of epochs 10k, and also before launching this script, please write one with the old unet to make sure we are doing everything correctly

kevinmicha and others added 4 commits May 17, 2021 10:52
@kevinmicha @zaccharieramzi
Made a list of run_ids
6f8b891 
Co-authored-by: Zaccharie Ramzi <[email protected]>
@kevinmicha @zaccharieramzi
Reduces n_gpus
da9f7a5 
Co-authored-by: Zaccharie Ramzi <[email protected]>
@kevinmicha @zaccharieramzi
Removed batch_size initialisation
91ec6d0 
Co-authored-by: Zaccharie Ramzi <[email protected]>
@kevinmicha @zaccharieramzi
Removed batch_size parameter
99f718b 
Co-authored-by: Zaccharie Ramzi <[email protected]>
zaccharieramzi
zaccharieramzi requested changes May 18, 2021
View reviewed changes
Copy link
Collaborator

@zaccharieramzi zaccharieramzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last few mistakes

kevinmicha and others added 3 commits May 18, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaccharieramzi zaccharieramzi zaccharieramzi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinmicha @zaccharieramzi