Skip to content

fix: add missing clearLogBuilds #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add missing clearLogBuilds #72

wants to merge 1 commit into from

Conversation

Sadhorsephile
Copy link

@Sadhorsephile Sadhorsephile commented Jul 12, 2024 •
edited
Loading

Problem

Some tests keep failing with such error:

`buildLogItems` is not empty. Tests should validate the contents of `buildLogItems` and call `clearBuildLog` before `tearDown`.

even after they are fixed and relaunched.

Solution

I've just added clearBuildLog in two places:

  • after TestFailure detection;
  • at the very start of tearDown.

@kevmoo
Copy link
Owner

kevmoo commented Jun 26, 2025

Is this still a thing?

@kevmoo kevmoo added the question Further information is requested label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sadhorsephile @kevmoo