Skip to content

Enforce Description section in PR body with optional flag - #19

Merged
timflannagan merged 3 commits into
mainfrom
chore/reject-empty-descriptions
Oct 31, 2025
Merged

timflannagan merged 3 commits into
mainfrom
chore/reject-empty-descriptions

Conversation

@timflannagan

@timflannagan timflannagan commented Oct 31, 2025 •

Copy link
Copy Markdown
Member

Description

Adds validation to ensure PRs include a non-empty # Description section.
Configurable via enforce_description input (default: true).
Invalid PRs receive do-not-merge/description-invalid label.

Change Type

/kind feature

Changelog

Adds validation to ensure PRs include a non-empty # Description section. Configurable via enforce_description input (default: true). Invalid PRs receive do-not-merge/description-invalid label.

Additional Notes

Adds validation to ensure PRs include a non-empty # Description section.
Configurable via enforce_description input (default: true).
Invalid PRs receive do-not-merge/description-invalid label.

Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan
timflannagan force-pushed the chore/reject-empty-descriptions branch from e7c9bad to 17c4997 Compare October 31, 2025 18:34
Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan
timflannagan force-pushed the chore/reject-empty-descriptions branch from 16403a3 to bb9da91 Compare October 31, 2025 18:42
GitHub returns PR bodies with \r\n (CRLF) line endings, but the
regex uses ^# in multiline mode which only matches after \n.
This caused the Description regex to fail to match.

Fixed by normalizing all \r\n to \n before processing.

Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan
timflannagan merged commit f15977b into main Oct 31, 2025
3 checks passed
@timflannagan
timflannagan deleted the chore/reject-empty-descriptions branch October 31, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant