Skip to content

pkg,internal: Add test as a valid kind type #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timflannagan merged 1 commit into from
Jun 24, 2026
Merged

pkg,internal: Add test as a valid kind type #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/labeler/labeler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,11 @@ func TestInvalidChangelogKindCombinations(t *testing.T) {
body: "/kind cleanup\n/kind flake\n```release-note\nNONE\n```",
wantAdd: []string{fmt.Sprintf("kind/%s", kinds.Cleanup), fmt.Sprintf("kind/%s", kinds.Flake), labels.ReleaseNoteNoneLabel},
},
{
name: "test with NONE accepted",
body: "/kind test\n```release-note\nNONE\n```",
wantAdd: []string{fmt.Sprintf("kind/%s", kinds.Test), labels.ReleaseNoteNoneLabel},
},
}

for _, tc := range tests {
Expand Down
3 changes: 3 additions & 0 deletions pkg/kinds/kinds.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ const (
Install = "install"
// Bump is a kind label that indicates the PR is a dependency bump.
Bump = "bump"
// Test is a kind label that indicates the PR affects tests.
Test = "test"

// DeprecatedNewFeature is a deprecated kind label that indicates the PR is a new feature.
DeprecatedNewFeature = "new_feature"
Expand All @@ -40,6 +42,7 @@ var SupportedKinds = map[string]bool{
Flake: true,
Install: true,
Bump: true,
Test: true,
}

// DeprecatedKindMap maps old kind values to their new equivalents.
Expand Down
Loading