Conversation
…t, n4 bg option Agent-Logs-Url: https://github.com/khanlab/SPIMquant/sessions/d973790d-eb1b-4730-b51a-704815237200 Co-authored-by: akhanf <11492701+akhanf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update zoom montage QC PNGs for better visibility and options
feat: improve zoom montage QC PNGs — better mask color, no-mask output, n4 bg option
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ROI zoom montage QC figures had a yellow mask overlay (hard to see on grayscale), produced only one output per run, and always used the raw SPIM as background.
Changes
Mask overlay color
"spring"(yellow) →"Reds"(red), which is visually distinct on grayscale SPIM dataNo-mask output
qc_segmentation_roi_zoom/qc_vessels_roi_zoomrule now produces two PNGs:..._desc-{desc}_roimontage.png— with red mask overlay (unchanged filename)..._desc-{desc}nomask_roimontage.png— raw SPIM, no overlaynomasksuffix on thedescentity ensures the two files are adjacent in alphanum sortN4-corrected background (
--qc_roi_zoom_bg_n4)--correction_method n4, uses the N4 bias-field corrected OME-Zarr as the background image instead of raw SPIMFiles changed
workflow/scripts/qc_segmentation_roi_zoom.pyworkflow/rules/qc.smkpng_nomaskoutput, conditionalspim_n4input,use_n4_bgparamworkflow/Snakefileall_participantfor seg and vesselconfig/snakebids.yml--qc_roi_zoom_bg_n4CLI option