[kie-issues#1821][CVE]-2023-0833 Updating okhttp#1438
Open
LightGuard wants to merge 1 commit intokiegroup:7.67.x-bluefrom
Open
[kie-issues#1821][CVE]-2023-0833 Updating okhttp#1438LightGuard wants to merge 1 commit intokiegroup:7.67.x-bluefrom
LightGuard wants to merge 1 commit intokiegroup:7.67.x-bluefrom
Conversation
Had to go through a number of changes to get this all correct. The versions of anything from squareup need to be correct, but that also ended up needing Bouncy Castle for some of the tests as well. Signed-off-by: Jason Porter <[email protected]>
Member
Author
That doesn't make any sense. |
yesamer
approved these changes
Feb 25, 2025
yesamer
reviewed
Feb 25, 2025
| <!-- Add this to match other versions of okhttp3 and okio used elsewhere --> | ||
| <version.com.squareup.okhttp3>4.12.0</version.com.squareup.okhttp3> | ||
| <version.com.squareup.okio>3.6.0</version.com.squareup.okio> | ||
| <version.org.bouncycastle>1.78.1</version.org.bouncycastle> |
Member
There was a problem hiding this comment.
@LightGuard Why we need to declare those versions here? Can't we use the same declared in the parent pom in droolsjbpm-build-bootstrap ?
Member
Author
There was a problem hiding this comment.
No idea. I have a duplicate class issue locally, which does not appear to be related. Are other builds green without this change?
Member
There was a problem hiding this comment.
@LightGuard Related PRs get merged, thus I guess this PR is no longer necessary
//cc @baldimir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to kiegroup/droolsjbpm-build-bootstrap#2556 and kiegroup/jbpm-work-items#309
Also fixes apache/incubator-kie-issues#1821