[NO-ISSUE] bump mvel to 2.5.4.Final - #226
Merged
Merged
Conversation
tkobayas
commented
Aug 28, 2026
| ksession.insert(john); | ||
| assertThat(ksession.fireAllRules()).isEqualTo(1); | ||
| assertThat(john.getMoney()).isEqualTo(new BigDecimal( 0 )); | ||
| assertThat(john.getMoney()).isEqualByComparingTo(new BigDecimal( 0 )); |
Author
There was a problem hiding this comment.
The result is BigDecimal 0.0, so failed with isEqualTo. The scale difference was introduced by mvel/mvel#321. I think using isEqualByComparingTo is rather correct, because it doesn't make sense to be strict about scale when calculating with double.
tkobayas
marked this pull request as draft
August 28, 2026 09:40
Author
It's another issue in mvel2. mvel/mvel@043303ce was a valid fix, but it revealed a latent bug in Fold.java. Need to fix mvel2 and release a new version before drools consumes it. |
Author
|
Fixed in mvel 2.5.4.Final, so bumping again. |
tkobayas
marked this pull request as ready for review
September 2, 2026 07:49
baldimir
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
referenced Pull Requests: