Cleanup interface

[kimkulling]

Summary by CodeRabbit

• Refactor

  • Updated method naming to follow a consistent style.
  • Improved code clarity by simplifying constructor initialization.
  • Enhanced method performance with compile-time and exception guarantees.

• Style

  • Aligned method names with standard naming conventions for better readability.

[coderabbitai]

Walkthrough

The TBitField template class was updated by replacing its user-defined default constructor with a compiler-generated one, initializing its member variable at the point of declaration. The constructor taking an initial value was consolidated to a single definition. The method GetMask() was renamed to getMask(). The getBit() method was made constexpr and noexcept. No functional behavior was changed.

Changes

File	Change Summary
include/cppcore/Common/TBitField.h	Replaced user-defined default constructor with = default and in-class member initialization; consolidated init constructor; renamed GetMask() to getMask(); made getBit() constexpr and noexcept.

Poem

In fields of bits where changes spark,
Constructors now are light and stark.
From GetMask to getMask we hop,
constexpr leaps that never stop!
Cleaner code with every thread—
A rabbit’s joy in bits is spread.
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f077725 and fef1a6b.

📒 Files selected for processing (1)

• include/cppcore/Common/TBitField.h (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• include/cppcore/Common/TBitField.h

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

include/cppcore/Common/TBitField.h (3)

40-40: Prefer constexpr / noexcept on the default ctor.

The class is a lightweight value-type wrapper; marking the default constructor constexpr and noexcept allows compile-time use and better optimisation without changing semantics.

-    TBitField() = default;
+    constexpr TBitField() noexcept = default;

---

79-79: Use uniform initialisation for mBitMask.

Initialising with brace syntax avoids narrowing and is the modern idiom:

-    T mBitMask = 0;
+    T mBitMask{0};

---

89-90: getMask() can also be constexpr / noexcept.

The method is a trivial value return; making it constexpr and noexcept costs nothing and improves usability:

-inline T TBitField<T>::getMask() const {
+inline constexpr T TBitField<T>::getMask() const noexcept {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f01433e and f077725.

📒 Files selected for processing (1)

• include/cppcore/Common/TBitField.h (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (1)

include/cppcore/Common/TBitField.h (1)

49-53: Ensure all call-sites were renamed to getMask().

GetMask() → getMask() is a silent breaking change for every translation unit including this header.
Please run a quick search / build to confirm nothing still relies on the old spelling.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud