Skip to content

Add MCP Shield security scan #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thuggeelya wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add MCP Shield security scan #37

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15fa72a
Add MCP Shield security scan
Mar 4, 2026
b723e6c
Use local build instead of published npm package
Mar 4, 2026
c13b81d
Fix: use pnpm and pin action to SHA
Mar 4, 2026
72ce34b
update mcp-shield-action to latest v1 (adds SARIF + CWE)
thuggeelya Mar 5, 2026
14393a6
Update MCP Shield badge score to 78
Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/mcp-shield.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: MCP Shield

on:
push:
branches: [main]
pull_request:
branches: [main]

jobs:
scan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 20
- run: npm ci
- run: npm run build
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
- uses: thuggeelya/mcp-shield-action@v1
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
with:
server: 'node dist/index.js'
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

[![npm version](https://badge.fury.io/js/@kimsungwhee%2Fapple-docs-mcp.svg)](https://badge.fury.io/js/@kimsungwhee%2Fapple-docs-mcp)
[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
[![MCP Shield](https://img.shields.io/badge/MCP_Shield-B_(75)-yellowgreen)](https://github.com/thuggeelya/mcp-shield)
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use a workflow-backed badge instead of a hardcoded score.

This badge is static and will drift from real scan results; it also links to the tool repo instead of this project’s scan history.

Proposed fix 
-[![MCP Shield](https://img.shields.io/badge/MCP_Shield-B_(75)-yellowgreen)](https://github.com/thuggeelya/mcp-shield)
+[![MCP Shield](https://github.com/kimsungwhee/apple-docs-mcp/actions/workflows/mcp-shield.yml/badge.svg)](https://github.com/kimsungwhee/apple-docs-mcp/actions/workflows/mcp-shield.yml)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
[![MCP Shield](https://img.shields.io/badge/MCP_Shield-B_(75)-yellowgreen)](https://github.com/thuggeelya/mcp-shield)
[![MCP Shield](https://github.com/kimsungwhee/apple-docs-mcp/actions/workflows/mcp-shield.yml/badge.svg)](https://github.com/kimsungwhee/apple-docs-mcp/actions/workflows/mcp-shield.yml)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@README.md` at line 5, The README contains a hardcoded MCP Shield badge ("MCP
Shield" image and link to https://github.com/thuggeelya/mcp-shield) that can
drift from real scan results; replace it with a workflow-backed badge that
points to this repository's GitHub Actions workflow run status for the scanner
(use the repository-specific workflow badge URL and link to the workflow run
history), and ensure the badge's alt text remains descriptive (e.g., "MCP Shield
Scan") so the badge reflects live scan results and links to this project's scan
history rather than the tool repo.

Copy link
Copy Markdown
Author

@thuggeelya thuggeelya Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai This is intentional. The hardcoded badge displays the score and grade (e.g. "B (75)") which a workflow status badge cannot show — it only indicates pass/fail. The link to the tool repo is also intentional for discoverability.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thuggeelya, understood — that's a reasonable trade-off. A workflow status badge can only reflect pass/fail, whereas the hardcoded badge surfaces the actual grade and numeric score at a glance, and the link to the tool repo aids discoverability. I'll defer to your judgment here.


Apple Developer Documentation MCP Server - Access Apple's official developer docs, frameworks, APIs, SwiftUI, UIKit, and WWDC videos through Model Context Protocol. Search iOS, macOS, watchOS, tvOS, and visionOS documentation with AI-powered natural language queries. Get instant access to Swift/Objective-C code examples, API references, and technical guides directly in Claude, Cursor, or any MCP-compatible AI assistant.

Expand Down