-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: jest integration #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||
(useKeyboardAnimation as jest.Mock).mockReturnValue({ | ||
height: new Animated.Value(300), | ||
progress: new Animated.Value(1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's better to split these object to fisrtPosition, secondPosition, thirdPosition?
const thirdPosition = {
height: new Animated.Value(300),
progress: new Animated.Value(1),
};
(useKeyboardAnimation as jest.Mock).mockReturnValue(thirdPosition);
c60c988
to
5cfef18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
example
Anything related to example project
tests
You added or changed unit tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Will fix #101
💡 Motivation and Context
Right now it's not possible to write jest tests for components, that are using this library. To overcome the limitation I added
mock
and wrote several test cases as examples.📢 Changelog
CI
example
tests;Docs
Jest
🤔 How Has This Been Tested?
Tested locally and on CI that tests are working fine.
📝 Checklist