Skip to content

feat: add navigationBarTranslucent prop #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Feb 24, 2023

📜 Description

Added new navigationBarTranslucent prop on KeyboardProvider.

💡 Motivation and Context

To make it more customizable and support translucent navigation bar I decided to add a new prop called navigationBarTranslucent. This prop follows the same pattern as statusBarTranslucent.

Fixes #119

📢 Changelog

JS

  • updated specs for fabric codegen;

Android

  • added handling of new property (if property is set to true, then we are setting 0 bottom padding - the same logic is already used for controling status bar transparency);

🤔 How Has This Been Tested?

Manually tested on:

  • Pixel 3a (API 33, emulator);
  • Pixel 6 Pro (API 28, emulator)

📸 Screenshots (if appropriate):

Before After
image image

📝 Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko self-assigned this Feb 24, 2023
@kirillzyusko kirillzyusko added the 🤖 android Android specific label Feb 24, 2023
@kirillzyusko kirillzyusko marked this pull request as ready for review February 27, 2023 15:37
@kirillzyusko kirillzyusko merged commit d86fbd1 into main Feb 28, 2023
@kirillzyusko kirillzyusko deleted the bugfix/119-navigation-bar-translucent branch February 28, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Android specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyboardProvider breaks translucent system navigation bar
1 participant