Conversation
Always include a layers field, potentially empty, rather than excluding it from the manifest, as required by the OCI image spec JSON schema. Signed-off-by: Angel Misevski <amisevsk@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation satisfies the OCI requirement and includes effective regression coverage; APPROVE.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures layerless ModelKits remain OCI-compliant by serializing an empty layers array.
Changes:
- Initializes layer and diff-ID slices as non-nil.
- Warns when packing a layerless ModelKit.
- Adds regression coverage for
"layers":[].
| File | Description |
|---|---|
pkg/lib/filesystem/local-storage.go |
Preserves empty layer arrays in manifests. |
pkg/lib/filesystem/local-storage_test.go |
Verifies layerless manifest serialization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Always include a layers field, potentially empty, rather than excluding it from the manifest, as required by the OCI image spec JSON schema. Previously, packing a ModelKit with no layers would entirely omit the
layersfield on the manifest, which causes issues in some registries.Linked issues
N/A
AI-Assisted Code