Make env.py publically accessible, without starting the JVM #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, better to keep backward compatibility 😀 |
|
Added the shim; adding a deprecated decoration would require adding deprecated as a dependency, and jnius currently has no dependencies (except the JDK of course). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a usecase where I wish to know the JDK version before starting Jnius.
For instance, JDK24+ will need certain options to suppress warnings about native things.
I thought it would be handy to get the JDK location from jnius, but before jnius starts the JVM.
This PR moves env.py into jnius_config, so its accessible before jnius starts.
If thought necessary for backwards compatibility, I can make a jnius/env.py that has deprecates imports from jnius_config/env.py?