Skip to content

Conversation

T-Dynamos
Copy link
Contributor

@T-Dynamos T-Dynamos commented Jul 26, 2025

This PR adds python 3.13 support, we can't set default version to 3.13 just yet as in latest python, distutils was removed, so a lot of recipes need updating.

@T-Dynamos T-Dynamos force-pushed the python-update branch 2 times, most recently from a483a9d to 24d1da9 Compare July 26, 2025 19:13
@T-Dynamos T-Dynamos changed the title [WIP] python: update to 3.13 python: update to 3.13 Aug 16, 2025
@T-Dynamos T-Dynamos force-pushed the python-update branch 6 times, most recently from 6c99220 to d54d5a7 Compare August 17, 2025 05:51
@T-Dynamos T-Dynamos force-pushed the python-update branch 7 times, most recently from dc86b9e to 308d126 Compare August 19, 2025 14:11
@T-Dynamos T-Dynamos changed the title python: update to 3.13 python: add 3.13 support Aug 20, 2025
@T-Dynamos T-Dynamos force-pushed the python-update branch 6 times, most recently from fc5223d to ecb34a7 Compare August 20, 2025 06:20
@T-Dynamos T-Dynamos force-pushed the python-update branch 2 times, most recently from 7cb4f3f to 38682dc Compare August 20, 2025 07:03
@T-Dynamos T-Dynamos marked this pull request as ready for review August 20, 2025 07:48
@T-Dynamos
Copy link
Contributor Author

This PR is ready for review.

I have tested python 3.13 + kivy master + sdl3 bootstrap.

@T-Dynamos T-Dynamos marked this pull request as draft August 25, 2025 08:20
@T-Dynamos T-Dynamos marked this pull request as ready for review August 25, 2025 15:18
@kuzeyron kuzeyron added recipe core-providers Core code that's not a recipe labels Aug 31, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes from the pull request are also welcome, but will have better luck to get merged faster if they are in a dedicated pull request in order to keep this one as lean as possible.
Would you mind trying to create one pull request per recipes when possible?
For instance we don't take a big risk in merging the flask one relatively fast and that would make it easier to focus on the real thing which is the Python 3.13 support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was failing, but if you really need me to, I can make a separate PR. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just that I'm not sure when I'll get a chance to review/test the crispy one and getting the easy ones merge early would give us more chance to have the big one in. You prevent future conflicts and it's also easier to spot the changes that introduced regressions.
I'd really appreciate having one pull request per recipe when possible and I can do my best to merge them quick

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be non-contentious and could have its own pull request to keep the Python 3.13 pull request lean.
Even though I remember we did have in a past some issues with one recipe and parallel build, but it was easy to post since the error was at build time (and CI didn't complain here).

url = 'https://github.com/kivy/pyjnius/archive/{version}.zip'
name = 'pyjnius'
depends = [('genericndkbuild', 'sdl2', 'sdl3'), 'six']
site_packages_name = 'jnius'

hostpython_prerequisites = ["Cython~=3.1.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did see we're going with ~3.1.2 here https://github.com/kivy/pyjnius/blob/1.7.0/pyproject.toml#L5
But I'm wondering it this could be relaxed slightly to cython>=3.1,<=3.2

@AndreMiras
Copy link
Member

Impressive work thanks a mil 💪
I don't know when I'll get a chance to test the setup runtime with a real app, so let's try to get the easy changes merged early first so we can keep focus on reviewing Python 3.13 related changes better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-providers Core code that's not a recipe recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants