-
Notifications
You must be signed in to change notification settings - Fork 2k
python
: add 3.13
support
#3180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
python
: add 3.13
support
#3180
Conversation
a483a9d
to
24d1da9
Compare
24d1da9
to
5fe5697
Compare
6c99220
to
d54d5a7
Compare
b6b3a8e
to
954da58
Compare
dc86b9e
to
308d126
Compare
fc5223d
to
ecb34a7
Compare
7cb4f3f
to
38682dc
Compare
This PR is ready for review. I have tested python |
38682dc
to
8de1b8a
Compare
8de1b8a
to
c3b950a
Compare
c3b950a
to
3e9c98c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes from the pull request are also welcome, but will have better luck to get merged faster if they are in a dedicated pull request in order to keep this one as lean as possible.
Would you mind trying to create one pull request per recipes when possible?
For instance we don't take a big risk in merging the flask one relatively fast and that would make it easier to focus on the real thing which is the Python 3.13 support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI was failing, but if you really need me to, I can make a separate PR. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just that I'm not sure when I'll get a chance to review/test the crispy one and getting the easy ones merge early would give us more chance to have the big one in. You prevent future conflicts and it's also easier to spot the changes that introduced regressions.
I'd really appreciate having one pull request per recipe when possible and I can do my best to merge them quick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be non-contentious and could have its own pull request to keep the Python 3.13 pull request lean.
Even though I remember we did have in a past some issues with one recipe and parallel build, but it was easy to post since the error was at build time (and CI didn't complain here).
url = 'https://github.com/kivy/pyjnius/archive/{version}.zip' | ||
name = 'pyjnius' | ||
depends = [('genericndkbuild', 'sdl2', 'sdl3'), 'six'] | ||
site_packages_name = 'jnius' | ||
|
||
hostpython_prerequisites = ["Cython~=3.1.2"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did see we're going with ~3.1.2 here https://github.com/kivy/pyjnius/blob/1.7.0/pyproject.toml#L5
But I'm wondering it this could be relaxed slightly to cython>=3.1,<=3.2
Impressive work thanks a mil 💪 |
This PR adds python
3.13
support, we can't set default version to3.13
just yet as in latest python,distutils
was removed, so a lot of recipes need updating.