fix(Modal): ensure Modal has rounded bottom corners on larger viewports #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-rcsl-add-missing-padding-for-modal-with-header-only.surge.sh |
|
Size Change: +13 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
RobinCsl
force-pushed
the
rcsl/add-missing-padding-for-modal-with-header-only
branch
from
b7fc74b to
6108114
Compare
Deploying orbit with
|
| Latest commit: |
4bf8eda
|
| Status: | ⚡️ Build in progress... |
RobinCsl
force-pushed
the
rcsl/add-missing-padding-for-modal-with-header-only
branch
2 times, most recently
from
f594aec to
2b26ce7
Compare
DSil
reviewed
Jan 20, 2025
RobinCsl
force-pushed
the
rcsl/add-missing-padding-for-modal-with-header-only
branch
from
2b26ce7 to
d702555
Compare
@DSil thank you for the reminder, done! |
DSil
approved these changes
Jan 20, 2025
RobinCsl
force-pushed
the
rcsl/add-missing-padding-for-modal-with-header-only
branch
from
d702555 to
4bf8eda
Compare
RobinCsl
deleted the
rcsl/add-missing-padding-for-modal-with-header-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FEPLT-2208
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.ts✨
Description by Callstackai
This PR adds a new visual story for the Modal component with a header only, along with corresponding tests and snapshot files.
Diagrams of code changes
sequenceDiagram participant App participant Modal participant ModalHeader participant Illustration App->>Modal: Render Modal with header only Note over Modal: New variant added Modal->>ModalHeader: Render header with props ModalHeader->>Illustration: Render illustration Note over ModalHeader: Contains title, description<br/>and illustration Modal-->>App: Return Modal with header only Note over Modal: Supports mobile/desktop<br/>and fullPage variantsFiles Changed