chore: fix Playroom deployment #4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook staging is available at https://kiwicom-orbit-sarka-publish-actions-playroom-deployment.surge.sh Playroom staging is available at https://kiwicom-orbit-sarka-publish-actions-playroom-deployment.surge.sh/playroom |
|
Size Change: +1 B (0%) Total Size: 459 kB
ℹ️ View Unchanged
|
Deploying orbit with
|
| Latest commit: |
8d32cb8
|
| Status: | ⚡️ Build in progress... |
DSil
reviewed
Jan 24, 2025
scripts/post-changelog.mjs
Outdated
| @@ -100,7 +100,7 @@ const getPlayroomLink = (package_, tags) => { | |||
| if (package_ !== "orbit-components") return ""; | |||
|
|
|||
| const latestTag = tags.all.find(tag => tag.includes("@kiwicom/orbit-components@")); | |||
| const releaseVersion = latestTag.split("@").pop().replace(".", "-"); | |||
| const releaseVersion = latestTag.split("@").pop().replaceAll(".", "-"); | |||
| return `**Playroom for ${releaseVersion} is available [here](https://kiwicom-orbit-v${releaseVersion}.surge.sh)** 🕹️ \n`; | |||
There was a problem hiding this comment.
The first releaseVersion shows up as XX-YY-Z, instead of the normal semantic versioning XX.YY.Z
We could improve this here as well.
.github/workflows/publish.yml
Outdated
Comment on lines
81
to
82
| VERSION_TAG=$(git tag --list '@kiwicom/orbit-components@*' --sort=creatordate | sed '$!d' | sed -n '$ s|.*@||; s/\./-/gp') | ||
| echo "VERSION_TAG=$VERSION_TAG" >> $GITHUB_ENV |
sarkaaa
force-pushed
the
sarka/publish-actions-playroom-deployment
branch
3 times, most recently
from
3a82146 to
87990c8
Compare
DSil
approved these changes
Jan 24, 2025
sarkaaa
force-pushed
the
sarka/publish-actions-playroom-deployment
branch
from
87990c8 to
8d32cb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.ts✨
Description by Callstackai
This PR fixes the Playroom deployment by adding build steps for Playroom and Storybook in the GitHub Actions workflow, and updates the Playroom link generation in the changelog script.
Diagrams of code changes
sequenceDiagram participant CI as CI/CD Pipeline participant Build as Build Process participant Git as Git Operations participant Docs as Documentation CI->>Build: Execute build steps Note over Build: yarn tokens build Note over Build: yarn tailwind-preset build Note over Build: yarn components build Build->>Build: Build Playroom (new) Build->>Build: Build Storybook (new) CI->>Git: Get latest tag version Git-->>CI: Return version info CI->>Docs: Update changelog Note over Docs: Add Playroom link with version CI->>Git: Commit & push changelogFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.yml,.mjs. See list of supported languages.